[LOCAL][CI] Fix Helloworld ios jobs #45158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
cipolleschi
force-pushed
the
cipolleschi/fix-helloworld-ios-on-075
branch
2 times, most recently
from
eae5b99
to
7a8ff08
Compare
|
Need to update the cache key for build_hermes_macos in restore to |
cipolleschi
force-pushed
the
cipolleschi/fix-helloworld-ios-on-075
branch
from
7a8ff08
to
5e640f6
Compare
cipolleschi
commented
Jun 25, 2024
.github/workflows/test-all.yml
Outdated
| @@ -206,7 +206,7 @@ jobs: | |||
| - name: Restore Cached Artifacts | |||
| uses: actions/cache/[email protected] | |||
| with: | |||
| key: v2-hermes-osx-bin-${{ matrix.flavor }}-${{ needs.prepare_hermes_workspace.outputs.hermes-version }}-${{ needs.prepare_hermes_workspace.outputs.react-native-version }} | |||
| key: v2-hermes-artifacts-${{ matrix.flavor }}-${{ needs.prepare_hermes_workspace.outputs.hermes-version }}-${{ needs.prepare_hermes_workspace.outputs.react-native-version }} | |||
There was a problem hiding this comment.
this is a fix to optimize the build. I was using the wrong prefix in the previous PR.
cipolleschi
force-pushed
the
cipolleschi/fix-helloworld-ios-on-075
branch
6 times, most recently
from
1677a5c
to
703e987
Compare
Base commit: d3e0430 |
cipolleschi
force-pushed
the
cipolleschi/fix-helloworld-ios-on-075
branch
2 times, most recently
from
c3c26d8
to
49d395b
Compare
blakef
approved these changes
Jun 26, 2024
cortinico
approved these changes
Jun 26, 2024
cipolleschi
force-pushed
the
cipolleschi/fix-helloworld-ios-on-075
branch
from
49d395b
to
e7f4f05
Compare
This was referenced Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We changed the way we restore the Hermes binary, restoring it from artifacts rather than from cache.
This might have altered a little where the binary is stored and we need to update the path properly
Changelog:
[Internal] - Fix Helloworld ios jobs
Test Plan:
GHA are green