[RN][Testing] Update testing scripts to work with any version of React native #45201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
cipolleschi
force-pushed
the
cipolleschi/update-testing-scripts
branch
from
f670fbf
to
dbdb477
Compare
Base commit: 8db2995 |
cortinico
force-pushed
the
cipolleschi/update-testing-scripts
branch
from
dbdb477
to
b03d3f6
Compare
|
I tested this locally on the 0.75-branch and I was able to successfully e2e test the template 🎉 |
cortinico
approved these changes
Jul 3, 2024
| @@ -59,6 +61,7 @@ async function main() { | |||
|
|
|||
| Options: | |||
| --projectName The name of the new React Native project. | |||
| --currentBranch The current branch to checkout. | |||
There was a problem hiding this comment.
nit: this is a bit unclear. We should clarify that you're referring to the branch of the template repo
cortinico
pushed a commit
that referenced
this pull request
Jul 17, 2024
This was referenced Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
These changes updates the testing script so that it follow the approach described here.
In this way, the testing script:
rc.Xversion of the template before we releaserc.Xof React NativeChangelog:
[Internal] - Update testing script to work with any version of React Native
Test Plan:
Tested locally and verified that the script is packing a template and using the template when initializing the project.