[LOCAL][RN][CI] Improve stability of the Hermes pipeline #45142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
cipolleschi
force-pushed
the
cipolleschi/improve-build-hermes-mac-stability
branch
from
6fe235d
to
57ccdf8
Compare
Summary: This change is the first step in refactoring GHA so that they can be reused more easily across jobs. Its goal is also to be more reliable w.r.t. caches. That this change do: * moves `prepare_hermes_workspace` to a composite action * saves the `prepare_hermes_workspace` caches only on main * uploads the destination folder as an artifact so that we can use it later in the run * makes the `test-all`, `nightly` and `publish-release` workflow use the new composite action * updates the `setup-hermes-workspace` to download and use the artifact uploaded by `prepare_hermes_workspace` [Internal] - Factor out the prepare_hermes_workspace action Pull Request resolved: #45071 Test Plan: GHA in CI Reviewed By: cortinico Differential Revision: D58808087 Pulled By: cipolleschi fbshipit-source-id: 42c46bcf75fc73b2edfda9be62b5d0fe8a919a5d
cipolleschi
force-pushed
the
cipolleschi/improve-build-hermes-mac-stability
branch
7 times, most recently
from
44d5ad2
to
b460a60
Compare
Base commit: 986cf18 |
cipolleschi
force-pushed
the
cipolleschi/improve-build-hermes-mac-stability
branch
12 times, most recently
from
92b0f04
to
e60c265
Compare
cipolleschi
force-pushed
the
cipolleschi/improve-build-hermes-mac-stability
branch
4 times, most recently
from
438c1e0
to
8370225
Compare
cipolleschi
force-pushed
the
cipolleschi/improve-build-hermes-mac-stability
branch
2 times, most recently
from
6ac7e34
to
5644821
Compare
cipolleschi
force-pushed
the
cipolleschi/improve-build-hermes-mac-stability
branch
from
5644821
to
941259b
Compare
cortinico
approved these changes
Jun 25, 2024
blakef
approved these changes
Jun 25, 2024
This was referenced Jun 25, 2024
This was referenced Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The stability of the building Hermes pipeline was terrible due to how caches work in Github Actions.
I refactored the jobs to use a misxture of caches and artifacts to improve the jobs stability.
Now if a cache fails, we rebuild, as it should be, and we use Artifacts to move the prebuilts from a job to the next in the hermes build pipeline.
Artifacts are a bit slower, but not ratelimited, so we should not encounter 429s that makes the build faile.
Changelog:
[Internal] Stabilize the pipelines
Test Plan:
GHA is green.