[LOCAL][Release-Testing] Update the testing script to use the new template #45144
Conversation
facebook-github-bot
added
the
CLA Signed
cortinico
changed the title
| const pathToTemplate = path.join(templateRepoFolder, 'template'); | ||
|
|
||
| // Cleanup template clone folder | ||
| exec(`rm -rf ${templateRepoFolder}`); |
There was a problem hiding this comment.
Can we keep the cleanup?
There was a problem hiding this comment.
this folder does not exists anymore. it was pointing to /tmp/template which was the folder where we were cloning the template. We are not cloning the template anymore, so the folder is gone (line 247) and also the cleanup should go at this point.
scripts/e2e/init-template-e2e.js
Outdated
| const appPackageJson = JSON.parse( | ||
| fs.readFileSync(appPackageJsonPath, 'utf8'), | ||
| ); | ||
| appPackageJson.dependencies['react-native'] = |
There was a problem hiding this comment.
This shouldn't be a file:// dependency, just the version so it uses Verdaccio.
There was a problem hiding this comment.
nope, we want to use the exact same version we built in CI, so we download react native and we use the local file.
Having it to point to the locally published package means that we are going to rebuild react native locally, especially for Android, and we want to avoid that.
There was a problem hiding this comment.
Also, React Native is NOT published on Verdaccio, AFAIK.
Base commit: 4a8f0ee |
cipolleschi
force-pushed
the
cipollesschi/update-testing-script-for-cli
branch
from
787f4b8
to
3c48bdc
Compare
scripts/e2e/init-template-e2e.js
Outdated
| --directory ${directory} \ | ||
| --template ${templatePath} \ | ||
| --version next \ |
There was a problem hiding this comment.
Note: this won't work for rc.0 the next time.
Let's use it for now to unblock us but this now assumes the template is already published before be do the testing which is not the case.
I think the most correct way to do would be to:
- git clone the template
- git checkout to the
0.75-stablebranch (i.e. the same branch this script is executed from). - Update the template to align
react-nativeand all the@react-native/*dependencies. - Run
npm packto create a tarball of the template - Run
npx npx @react-native-community/cli@next init ${projectName} --template file://{path-to-packaged-template}
There was a problem hiding this comment.
the current approach doesn't work to test older versions of react native.
But also the steps highlighted here don't work, unless we have a release branch for the template as well. 🤔
The problem is that, when we test RC1, for example, React Native RC1 has not been published yet. And locally, the version of react native has not been updated yet. So:
- we are testing RC1, while the version in React native is still RC0
- we need to automate the creation of template release branches
🤔 🤔 🤔 🤔 🤔
There was a problem hiding this comment.
We can pass an extra parameter to the script, though... We can:
- pass a new
-vwith the version we want to test - run set-version to bump everything locally to the right version
- run the Verdaccio to publish the packages in the versions we actually want to test
- Assuming that we are in the release branch and that a release branch with the exact same name exists in the template, we can apply your steps.
cipolleschi
force-pushed
the
cipollesschi/update-testing-script-for-cli
branch
from
3c48bdc
to
09b3bd7
Compare
Summary:
This PR applies changes to the testing script for releases so that it can use the new template and the new react-native-community/cli
Changelog:
[Internal] - Make the release testing script use the community/cli
Test Plan:
Tested locally