Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_android_template → test_android_helloworld #44908

Closed
wants to merge 1 commit into from
Closed

test_android_template → test_android_helloworld #44908

wants to merge 1 commit into from

Conversation

blakef
Copy link
Contributor

@blakef blakef commented Jun 12, 2024

Summary:
Doing this just to validate changes. It doesn't have to land.

Changelog: [General] [Changed] - CircleCI test to Helloworld

Differential Revision: D58469912

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jun 12, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58469912

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58469912

blakef added a commit to blakef/react-native that referenced this pull request Jun 12, 2024
@blakef @facebook-github-bot
test_android_template → test_android_helloworld (facebook#44908)
2f0cd58 
Summary:
Pull Request resolved: facebook#44908

Doing this just to validate changes.  It doesn't have to land.

Changelog: [General] [Changed] - CircleCI test to Helloworld

Differential Revision: D58469912
@analysis-bot
Copy link

analysis-bot commented Jun 12, 2024 •
edited

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,443,778 -14
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,642,476 +7
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 4792671
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58469912

blakef added a commit to blakef/react-native that referenced this pull request Jun 13, 2024
@blakef @facebook-github-bot
test_android_template → test_android_helloworld (facebook#44908)
01a5bfb 
Summary:
Pull Request resolved: facebook#44908

Doing this just to validate changes.  It doesn't have to land.

Changelog: [General] [Changed] - CircleCI test to Helloworld

Differential Revision: D58469912
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58469912

blakef added a commit to blakef/react-native that referenced this pull request Jun 14, 2024
@blakef @facebook-github-bot
test_android_template → test_android_helloworld (facebook#44908)
23039d3 
Summary:
Pull Request resolved: facebook#44908

Doing this just to validate changes.  It doesn't have to land.

Changelog: [General] [Changed] - CircleCI test to Helloworld

Differential Revision: D58469912
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58469912

blakef added a commit to blakef/react-native that referenced this pull request Jun 14, 2024
@blakef @facebook-github-bot
test_android_template → test_android_helloworld (facebook#44908)
b46ae89 
Summary:
Pull Request resolved: facebook#44908

Doing this just to validate changes.  It doesn't have to land.

Changelog: [General] [Changed] - CircleCI test to Helloworld

Differential Revision: D58469912
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58469912

blakef added a commit to blakef/react-native that referenced this pull request Jun 14, 2024
@blakef @facebook-github-bot
test_android_template → test_android_helloworld (facebook#44908)
6605f41 
Summary:
Pull Request resolved: facebook#44908

Doing this just to validate changes.  It doesn't have to land.

Changelog: [General] [Changed] - CircleCI test to Helloworld

Differential Revision: D58469912
blakef added a commit to blakef/react-native that referenced this pull request Jun 14, 2024
@blakef @facebook-github-bot
test_android_template → test_android_helloworld (facebook#44908)
8dd6e19 
Summary:
Pull Request resolved: facebook#44908

Doing this just to validate changes.  It doesn't have to land.

Changelog: [General] [Changed] - CircleCI test to Helloworld

Differential Revision: D58469912
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58469912

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58469912

blakef added a commit to blakef/react-native that referenced this pull request Jun 14, 2024
@blakef @facebook-github-bot
test_android_template → test_android_helloworld (facebook#44908)
b1f3c7c 
Summary:
Pull Request resolved: facebook#44908

Doing this just to validate changes.  It doesn't have to land.

Changelog: [General] [Changed] - CircleCI test to Helloworld

Differential Revision: D58469912
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58469912

blakef added a commit to blakef/react-native that referenced this pull request Jun 14, 2024
@blakef @facebook-github-bot
test_android_template → test_android_helloworld (facebook#44908)
29a9ca1 
Summary:
Pull Request resolved: facebook#44908

Doing this just to validate changes.  It doesn't have to land.

Changelog: [General] [Changed] - CircleCI test to Helloworld

Differential Revision: D58469912
blakef added a commit to blakef/react-native that referenced this pull request Jun 14, 2024
@blakef @facebook-github-bot
test_android_template → test_android_helloworld (facebook#44908)
ec20c43 
Summary:
Pull Request resolved: facebook#44908

Doing this just to validate changes.  It doesn't have to land.

Changelog: [General] [Changed] - CircleCI test to Helloworld

Reviewed By: cipolleschi

Differential Revision: D58469912
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58469912

blakef added a commit to blakef/react-native that referenced this pull request Jun 17, 2024
@blakef @facebook-github-bot
test_android_template → test_android_helloworld (facebook#44908)
8015d80 
Summary:
Pull Request resolved: facebook#44908

Doing this just to validate changes.  It doesn't have to land.

Changelog: [General] [Changed] - CircleCI test to Helloworld

Reviewed By: cipolleschi

Differential Revision: D58469912
blakef added a commit to blakef/react-native that referenced this pull request Jun 17, 2024
@blakef @facebook-github-bot
test_android_template → test_android_helloworld but disabled until te…
739c7c2 
…mplate is removed (facebook#44908)

Summary:
Pull Request resolved: facebook#44908

Changelog: [General] [Changed] - CircleCI test to Helloworld, but disabled for now until we remove the template

Differential Revision: D58469912

Reviewed By: cipolleschi
@blakef @facebook-github-bot
test_android_template → test_android_helloworld but disabled until te…
4749f2b 
…mplate is removed (facebook#44908)

Summary:
Pull Request resolved: facebook#44908

Changelog: [General] [Changed] - CircleCI test to Helloworld, but disabled for now until we remove the template

Reviewed By: cipolleschi

Differential Revision: D58469912
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58469912

blakef added a commit to blakef/react-native that referenced this pull request Jun 17, 2024
@blakef @facebook-github-bot
test_android_template → test_android_helloworld but disabled until te…
f59f718 
…mplate is removed (facebook#44908)

Summary:
Pull Request resolved: facebook#44908

Changelog: [General] [Changed] - CircleCI test to Helloworld, but disabled for now until we remove the template

Differential Revision: D58469912

Reviewed By: cipolleschi
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 17, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in bc1735f.

@github-actions GitHub Actions
Copy link

This pull request was successfully merged by @blakef in bc1735f.

When will my fix make it into a release? | How to file a pick request?

@github-actions GitHub Actions
Copy link

This pull request was successfully merged by @blakef in f59f718.

When will my fix make it into a release? | How to file a pick request?

cipolleschi pushed a commit that referenced this pull request Jun 18, 2024
@blakef @cipolleschi
test_android_template → test_android_helloworld but disabled until te…
20ca94b 
…mplate is removed (#44908)

Summary:
Pull Request resolved: #44908

Changelog: [General] [Changed] - CircleCI test to Helloworld, but disabled for now until we remove the template

Reviewed By: cipolleschi

Differential Revision: D58469912

fbshipit-source-id: 718a774946bd70347697f18bbfc470b2897d2f87
@github-actions GitHub Actions
Copy link

This pull request was successfully merged by @blakef in 20ca94b.

When will my fix make it into a release? | How to file a pick request?

@blakef blakef mentioned this pull request Jun 18, 2024
Closed
This was referenced Jun 19, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@cipolleschi cipolleschi mentioned this pull request Jun 27, 2024
Merged
@cipolleschi cipolleschi mentioned this pull request Jul 9, 2024
Open
@cipolleschi cipolleschi mentioned this pull request Jul 29, 2024
Merged
This was referenced Aug 15, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blakef @facebook-github-bot @analysis-bot