Add new product field external_update_time to measure product update latency#2973
Closed
mshymon wants to merge 1 commit intofacebook:mainfrom
Closed
Add new product field external_update_time to measure product update latency#2973mshymon wants to merge 1 commit intofacebook:mainfrom
mshymon wants to merge 1 commit intofacebook:mainfrom
Conversation
Contributor
|
@mshymon has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
tzahgr
pushed a commit
that referenced
this pull request
Apr 1, 2025
…latency (#2973) Summary: ## Description In this PR I am adding a new product field to be passed to Meta side, which is `external_update_time` - a timestamp of when the woo product was last updated. We intend to use this field to measure a latency of when products get updated on the Meta side. ### Type of change - [x] New feature (non-breaking change which adds functionality) ## Screenshots N/A ## Test instructions * Automated testing * Run all unit tests: `npm run test:php` * Manual testing * In WooCommerce UI I updated one product and checked that Batch API request contains the new field and the timestamp value is correct. * Also triggered a feed upload and verified the new field is present in the feed file and the value is as expected ## Checklist - [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)) - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added tests and all the new and existing unit tests pass locally with my changes - [x] I have completed dogfooding, or I have conducted thorough due diligence to ensure that it does not break existing functionality. - A stand alone QA testing is not required, will be part of plugin release QA. ## Changelog entry One liner entry to be surfaced in changelog.txt Pull Request resolved: #2973 Reviewed By: gurtejrehal Differential Revision: D71965438 Pulled By: mshymon fbshipit-source-id: 80479cc83a8c7edab67e47c66c5c599ee0331168
SayanPandey
pushed a commit
to SayanPandey/facebook-for-woocommerce
that referenced
this pull request
Apr 1, 2025
…latency (facebook#2973) Summary: ## Description In this PR I am adding a new product field to be passed to Meta side, which is `external_update_time` - a timestamp of when the woo product was last updated. We intend to use this field to measure a latency of when products get updated on the Meta side. ### Type of change - [x] New feature (non-breaking change which adds functionality) ## Screenshots N/A ## Test instructions * Automated testing * Run all unit tests: `npm run test:php` * Manual testing * In WooCommerce UI I updated one product and checked that Batch API request contains the new field and the timestamp value is correct. * Also triggered a feed upload and verified the new field is present in the feed file and the value is as expected ## Checklist - [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)) - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added tests and all the new and existing unit tests pass locally with my changes - [x] I have completed dogfooding, or I have conducted thorough due diligence to ensure that it does not break existing functionality. - A stand alone QA testing is not required, will be part of plugin release QA. ## Changelog entry One liner entry to be surfaced in changelog.txt Pull Request resolved: facebook#2973 Reviewed By: gurtejrehal Differential Revision: D71965438 Pulled By: mshymon fbshipit-source-id: 80479cc83a8c7edab67e47c66c5c599ee0331168
This was referenced Apr 2, 2025
Merged
This was referenced Apr 10, 2025
Closed
Closed
mradmeta
pushed a commit
that referenced
this pull request
Apr 14, 2025
…latency (#2973) Summary: ## Description In this PR I am adding a new product field to be passed to Meta side, which is `external_update_time` - a timestamp of when the woo product was last updated. We intend to use this field to measure a latency of when products get updated on the Meta side. ### Type of change - [x] New feature (non-breaking change which adds functionality) ## Screenshots N/A ## Test instructions * Automated testing * Run all unit tests: `npm run test:php` * Manual testing * In WooCommerce UI I updated one product and checked that Batch API request contains the new field and the timestamp value is correct. * Also triggered a feed upload and verified the new field is present in the feed file and the value is as expected ## Checklist - [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)) - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added tests and all the new and existing unit tests pass locally with my changes - [x] I have completed dogfooding, or I have conducted thorough due diligence to ensure that it does not break existing functionality. - A stand alone QA testing is not required, will be part of plugin release QA. ## Changelog entry One liner entry to be surfaced in changelog.txt Pull Request resolved: #2973 Reviewed By: gurtejrehal Differential Revision: D71965438 Pulled By: mshymon fbshipit-source-id: 80479cc83a8c7edab67e47c66c5c599ee0331168
This was referenced Apr 18, 2025
This was referenced May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR I am adding a new product field to be passed to Meta side, which is
external_update_time- a timestamp of when the woo product was last updated. We intend to use this field to measure a latency of when products get updated on the Meta side.Type of change
Screenshots
N/A
Test instructions
npm run test:phpChecklist
Changelog entry
One liner entry to be surfaced in changelog.txt