Skip to content

feat: add timestamp during product prep to track sync latency#3506

Open
rithikb24 wants to merge 3 commits intofacebook:mainfrom
rithikb24:add_prepare_product_time
Open

feat: add timestamp during product prep to track sync latency#3506
rithikb24 wants to merge 3 commits intofacebook:mainfrom
rithikb24:add_prepare_product_time

Conversation

@rithikb24
Copy link
Copy Markdown
Contributor

@rithikb24 rithikb24 commented Jul 9, 2025

Description

To enhance latency tracking, a new field, product_prepare_time, will be added. This field will record the Unix timestamp when a product is prepared for synchronization with the Facebook catalog.

All synchronization go through prepare_product() function. This modification will enable the tracking of time elapsed from product preparation until its appearance in the Facebook/Meta catalog, allowing for latency health monitoring.

Motivation Doc for more comprehensive explanation

The changes are very similar to - #2973
If there were any concerns/issues post that change, please let me know

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

✅ I have commented my code, particularly in hard-to-understand areas, if any.
✅ I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes. (Tests Action Success Run)
✅ I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality.

Changelog entry

Todo

Test Plan

Automated testing

Tests Action Success Run)

Manual testing

  • Verified that Batch API requests include the new field and a correct timestamp value after adding a product.
  • Triggered a CSV upload and confirmed the presence of the new field in the Batch API request.
  • Observed feed upload results, with a CSV created for the feed (P1870450808).
  • A PasteBin URL (P1864804075) displays the request with the new field.

@rithikb24 rithikb24 requested a review from vinkmeta July 9, 2025 21:12
@rithikb24 rithikb24 marked this pull request as ready for review July 9, 2025 21:12
@rithikb24 rithikb24 marked this pull request as draft July 9, 2025 21:14
@rithikb24 rithikb24 changed the title feat: add variable to track sync latency feat: add timestamp during product prep to track sync latency Jul 11, 2025
@rithikb24 rithikb24 marked this pull request as ready for review July 15, 2025 14:55
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@rithikb24 has imported this pull request. If you are a Meta employee, you can view this in D78345034.

@rithikb24 rithikb24 added the feature: product sync Relating to syncing product data to Facebook. label Jul 15, 2025
@devbodaghe devbodaghe added CLA Signed changelog: add A new feature, function, or functionality was added. and removed CLA Signed feature: product sync Relating to syncing product data to Facebook. labels Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: add A new feature, function, or functionality was added. CLA Signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants