feat: add timestamp during product prep to track sync latency#3506
Open
rithikb24 wants to merge 3 commits intofacebook:mainfrom
Open
feat: add timestamp during product prep to track sync latency#3506rithikb24 wants to merge 3 commits intofacebook:mainfrom
rithikb24 wants to merge 3 commits intofacebook:mainfrom
Conversation
Contributor
|
@rithikb24 has imported this pull request. If you are a Meta employee, you can view this in D78345034. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To enhance latency tracking, a new field,
product_prepare_time, will be added. This field will record the Unix timestamp when a product is prepared for synchronization with the Facebook catalog.All synchronization go through
prepare_product()function. This modification will enable the tracking of time elapsed from product preparation until its appearance in the Facebook/Meta catalog, allowing for latency health monitoring.Motivation Doc for more comprehensive explanation
The changes are very similar to - #2973
If there were any concerns/issues post that change, please let me know
Type of change
Checklist
✅ I have commented my code, particularly in hard-to-understand areas, if any.
✅ I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes. (Tests Action Success Run)
✅ I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality.
Changelog entry
Todo
Test Plan
Automated testing
Tests Action Success Run)
Manual testing