Sync products that are out of stock#2952
Closed
francorisso wants to merge 1 commit intofacebook:mainfrom
Closed
Conversation
Contributor
|
@devbodaghe has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@francorisso merged this pull request in 2ef517a. |
tzahgr
pushed a commit
that referenced
this pull request
Mar 24, 2025
Summary: ## Description Currently items out of stock are not synced if the user has selected a setting in inventory to hide the products that are out of stock from the catalog. We want to synced them anyways. ### Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) ## Screenshots After clicking SYNC PRODUCTS in the plugin config: ### Before <img width="1329" alt="Screenshot 2025-03-18 at 17 29 39" src="https://github.com/user-attachments/assets/5c3c3ed4-727b-48d0-9196-4a3bb8e47c34" /> ### After <img width="1345" alt="Screenshot 2025-03-18 at 10 19 25" src="https://github.com/user-attachments/assets/919c398d-2daf-49f0-96a6-57eb2e2ba913" /> ## Test instructions npm run test:php ran was successful ## Checklist - [ ] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)) - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added tests and all the new and existing unit tests pass locally with my changes - [ ] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. ## Changelog entry sync products out of stock to meta despite visibility config Pull Request resolved: #2952 Reviewed By: vinkmeta Differential Revision: D71408859 Pulled By: francorisso fbshipit-source-id: 3de82ba398910edc7790fbceb90f75a183b7f301
Merged
SayanPandey
pushed a commit
to SayanPandey/facebook-for-woocommerce
that referenced
this pull request
Apr 1, 2025
Summary: ## Description Currently items out of stock are not synced if the user has selected a setting in inventory to hide the products that are out of stock from the catalog. We want to synced them anyways. ### Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) ## Screenshots After clicking SYNC PRODUCTS in the plugin config: ### Before <img width="1329" alt="Screenshot 2025-03-18 at 17 29 39" src="https://github.com/user-attachments/assets/5c3c3ed4-727b-48d0-9196-4a3bb8e47c34" /> ### After <img width="1345" alt="Screenshot 2025-03-18 at 10 19 25" src="https://github.com/user-attachments/assets/919c398d-2daf-49f0-96a6-57eb2e2ba913" /> ## Test instructions npm run test:php ran was successful ## Checklist - [ ] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)) - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added tests and all the new and existing unit tests pass locally with my changes - [ ] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. ## Changelog entry sync products out of stock to meta despite visibility config Pull Request resolved: facebook#2952 Reviewed By: vinkmeta Differential Revision: D71408859 Pulled By: francorisso fbshipit-source-id: 3de82ba398910edc7790fbceb90f75a183b7f301
This was referenced Apr 10, 2025
Closed
Closed
mradmeta
pushed a commit
that referenced
this pull request
Apr 14, 2025
Summary: ## Description Currently items out of stock are not synced if the user has selected a setting in inventory to hide the products that are out of stock from the catalog. We want to synced them anyways. ### Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) ## Screenshots After clicking SYNC PRODUCTS in the plugin config: ### Before <img width="1329" alt="Screenshot 2025-03-18 at 17 29 39" src="https://github.com/user-attachments/assets/5c3c3ed4-727b-48d0-9196-4a3bb8e47c34" /> ### After <img width="1345" alt="Screenshot 2025-03-18 at 10 19 25" src="https://github.com/user-attachments/assets/919c398d-2daf-49f0-96a6-57eb2e2ba913" /> ## Test instructions npm run test:php ran was successful ## Checklist - [ ] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)) - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added tests and all the new and existing unit tests pass locally with my changes - [ ] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. ## Changelog entry sync products out of stock to meta despite visibility config Pull Request resolved: #2952 Reviewed By: vinkmeta Differential Revision: D71408859 Pulled By: francorisso fbshipit-source-id: 3de82ba398910edc7790fbceb90f75a183b7f301
This was referenced Apr 18, 2025
This was referenced May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently items out of stock are not synced if the user has selected a setting in inventory to hide the products that are out of stock from the catalog. We want to synced them anyways.
Type of change
Please delete options that are not relevant.
Screenshots
After clicking SYNC PRODUCTS in the plugin config:
Before
After
Test instructions
npm run test:php ran was successful
Checklist
Changelog entry
sync products out of stock to meta despite visibility config