Conversation
sol-loup
approved these changes
Mar 14, 2025
Contributor
|
@vinkmeta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
tzahgr
pushed a commit
that referenced
this pull request
Mar 17, 2025
Summary: ### Changes proposed in this Pull Request: Updated Pull Request Template ### Changelog entry > Updated Pull Request Template Pull Request resolved: #2948 Reviewed By: sol-loup, ajello-meta, jczhuoMeta, gurtejrehal Differential Revision: D71211859 Pulled By: vinkmeta fbshipit-source-id: 45992254125bfc3ce3c267d7cb3afd1a73d0bb01
Merged
vahidkay-meta
added a commit
that referenced
this pull request
Mar 24, 2025
Add - Items batch request and response tests by @nrostrow-meta in #2917 Tweak - Always run PHP-based github workflows by @carterbuce in #2926 Fix - feed upload error "feed_column_count_mismatch" when product has multiple colors separated by a comma by @mshymon in #2947 Tweak - Updated Pull Request Template by @vinkmeta in #2948 Tweak - Enabled PHPUnit code coverage report generation by @carterbuce in #2893 Dev - Improved readability of function prepare_product() in fbproduct.php by @mshymon in #2889
This was referenced Apr 10, 2025
Closed
Closed
This was referenced Apr 18, 2025
This was referenced May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Updated Pull Request Template
Changelog entry