Skip to content

Develop -> Master#2307

Merged
mslipper merged 34 commits intomasterfrom
develop
Mar 10, 2022
Merged

Develop -> Master#2307
mslipper merged 34 commits intomasterfrom
develop

Conversation

@mslipper
Copy link
Collaborator

  • maintenance: contracts README update 1
  • Version Packages
  • changeset: cleanup packages
  • indexer: fix metrics
  • refactor(tests): migrate from smock v1 to smock v2
  • indexer: fix package.json
  • linting: speed up with new config
  • indexer: reduce DB load
  • Use promauto
  • fix(sdk): typo in constructor docstring
  • feat(sdk): support autogenerated docs
  • feat(sdk): update README and release 1.0.0
  • fix(mr): update README to reflect latest version
  • maint: use release instead of regenesis
  • Version Packages
  • ops: Build cleanups
  • feat: introduces the new BaseServiceV2 class
  • fix: tighten ProviderLike SDK typings
  • feat: rewrite relayer with BaseServiceV2
  • fix(sdk): update package json with correct repo
  • main(ct): finish updating contracts readme
  • feat: add index for tasks
  • feat(rhc): refactor service using BaseServiceV2
  • feat: add MIN_L1_TX_SIZE configuration
  • feat: extract gas limit estimation to driver, add 20% buffer
  • feat(cmn): gracefully handle BaseServiceV2 exits
  • Delete unused variables
  • ops: Fix gas oracle in docker compose
  • proxyd: Don't hit Redis when the out of service interval is zero
  • feat (indexer): cleanup; rpc flags; pagination

smartcontracts and others added 30 commits February 3, 2022 10:01
Changes our branching model to use release/ branches instead of
regenesis/ branches now that we no longer plan to perform any
regenesis-style upgrades. Using release/ branches will reduce confusion
from people who see a regenesis/ branch and assume (logically) that this
branch will result in a regenesis.
Cleans up a bunch of configuration in `ops/`, in preparation for switching most of our build configuration to CircleCI. Changes include:

1. Removing the "builder image" concept in favor of a single multi-target Dockerfile. Once this goes live on CircleCI, we'll be able to leverage Docker Layer caching more effectively.
2. Fixes the nightly build, which is currently failing on the legacy batch submitter.
3. Removes the legacy rpc-proxy since it isn't used anywhere anymore.
4. Re-enables CODEOWNERS.
5. Removes the `docker-compose-nobuild.yml` file, since the main `docker-compose.yml` file now supports images and builds.

Meta:

- Fixes ENG-1838
Introduces the new BaseServiceV2 class to eventually replace the older
BaseService class. BaseServiceV2 includes many convenience features like
automatic environment variable and argv parsing.
ProviderLike is too loose because it allows "any" to be ProviderLike.
This tightens the type to only include strings or ethers.Provider
objects.
Rewrites the message-relayer service to use BaseServiceV2. Significantly
reduces the footprint of the message-relayer and enforces stronger input
validation.
feat: introduce the new BaseServiceV2 class
…elease

maint: use release instead of regenesis branches
Updates the package.json file for the SDK to include the correct
repository link.
maintenance: contracts README update 1
fix(sdk): update package json with correct repo
Updates various parts of the contracts README, primarily making sure
that the process for deploying the contracts is up to date.
fix(mr): update README to reflect latest version
main(ct): finish updating contracts readme
create an index.ts file in the tasks folder which re-exports each of the tasks
Also, change all of the tasks imports in hardhat.config.ts to './tasks'
Refactors the replica-healthcheck service using the BaseServiceV2 base
class. Significantly reduces the complexity of the service overall (the
whole service now fits within < 200 loc). Updates the README to reflect
these changes and removes many now-unused dependencies.
On mainnet we are seeing out of exceptions with some frequency. In all
of these cases it appears we are very, very close to being successful.
This commit extracts the internal calls performed by RawTransact into
the driver and then adds a buffer to limit the possibility of losing
money on the reverting transactions, since these very large transactions
are costly especially in the current fee market.
feat(rhc): refactor service using BaseServiceV2
Gracefully handles BaseServiceV2 exits by default. Adds a new function
for stopping the service and catches SIGTERM and SIGINT correctly.
Create "barrel" index file for hardhat tasks
feat(cmn): gracefully handle BaseServiceV2 exits
feat: add MIN_L1_TX_SIZE configuration
feat: extract gas limit estimation to driver, add 20% buffer
When the out of service interval is zero, `proxyd` will send a `SETEX` command to Redis with a zero expiry. This is technically an error, and causes messages like `error setting backend unavailable ERR invalid expire time in setex` to appear in the logs. Users won't notice the issue since `proxyd` can continue working when Redis returns an error, but we should clean this up nonetheless since these problems appear in our alerting.
mslipper and others added 4 commits March 9, 2022 15:16
ops: Fix gas oracle in docker compose
proxyd: Don't hit Redis when the out of service interval is zero
indexer: add pagination metadata for deposit, withdrawal endpoints
@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2022

🦋 Changeset detected

Latest commit: 317914c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@eth-optimism/message-relayer Minor
@eth-optimism/batch-submitter-service Patch
@eth-optimism/replica-healthcheck Major
@eth-optimism/proxyd Patch
@eth-optimism/common-ts Patch
@eth-optimism/sdk Patch
@eth-optimism/contracts Patch
@eth-optimism/data-transport-layer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 2-reviewers M-ci Meta: ci related work A-ops Area: ops A-pkg-sdk Area: packages/sdk labels Mar 10, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2307 (317914c) into master (dfd5ac6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2307   +/-   ##
=======================================
  Coverage   80.08%   80.08%           
=======================================
  Files          77       77           
  Lines        2460     2460           
  Branches      450      450           
=======================================
  Hits         1970     1970           
  Misses        490      490           
Flag Coverage Δ
contracts 99.29% <ø> (ø)
core-utils 86.77% <ø> (ø)
data-transport-layer 49.72% <ø> (ø)
sdk 55.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/sdk/src/interfaces/types.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfd5ac6...317914c. Read the comment docs.

@mslipper mslipper merged commit 161e4cf into master Mar 10, 2022
theochap pushed a commit that referenced this pull request Dec 10, 2025
## Overview

Changes the `sequencer.enabled` flag to a more generic `mode` flag that
can be used to specify different modes of operation for the node. Also
wires this flag up to the `NodeBuilder`.

closes #2307
theochap pushed a commit that referenced this pull request Jan 14, 2026
## Overview

Changes the `sequencer.enabled` flag to a more generic `mode` flag that
can be used to specify different modes of operation for the node. Also
wires this flag up to the `NodeBuilder`.

closes #2307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ops Area: ops A-pkg-sdk Area: packages/sdk M-ci Meta: ci related work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants