This repository was archived by the owner on Jan 16, 2026. It is now read-only.
feat(bin/node): Change sequencer.enabled -> mode#2342
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the node configuration flag from sequencer.enabled to a generic mode option and connects it through the builder.
- Introduces
with_modeonRollupNodeBuilderand movesmodeinto theRollupNodestruct - Defines
FromStrforNodeModeto parse CLI input - Removes duplicate mode assignment in
RollupNodeBuilder::build
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/node/service/src/service/standard/builder.rs | Added with_mode setter and wired mode into RollupNode |
| crates/node/service/src/service/mode.rs | Implemented FromStr for NodeMode |
Comments suppressed due to low confidence (3)
crates/node/service/src/service/mode.rs:18
- Consider defining a custom error type (e.g.,
ParseNodeModeError) instead of usingStringso you can implementstd::error::Errorand provide richer context.
type Err = String;
crates/node/service/src/service/mode.rs:17
- Add unit tests for parsing
NodeModewith valid inputs ("validator","sequencer") and invalid cases to ensure theFromStrimplementation behaves as expected.
impl std::str::FromStr for NodeMode {
crates/node/service/src/service/mode.rs:7
- The
NodeModeenum lacks a doc comment. Consider adding a brief description of its purpose and the meaning of each variant for maintainability.
pub enum NodeMode {
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
refcell
reviewed
Jul 7, 2025
fa3b6a0 to
5178b10
Compare
5178b10 to
9bea18d
Compare
## Overview Changes the `sequencer.enabled` flag to a more generic `mode` flag that can be used to specify different modes of operation for the node. Also wires this flag up to the `NodeBuilder`.
9bea18d to
4c0033c
Compare
refcell
approved these changes
Jul 7, 2025
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
## Overview Changes the `sequencer.enabled` flag to a more generic `mode` flag that can be used to specify different modes of operation for the node. Also wires this flag up to the `NodeBuilder`. closes op-rs/kona#2307
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
## Overview Changes the `sequencer.enabled` flag to a more generic `mode` flag that can be used to specify different modes of operation for the node. Also wires this flag up to the `NodeBuilder`. closes #2307
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Changes the
sequencer.enabledflag to a more genericmodeflag that can be used to specify different modes of operation for the node. Also wires this flag up to theNodeBuilder.closes #2307