feat: add MIN_L1_TX_SIZE configuration#2289
feat: add MIN_L1_TX_SIZE configuration#2289mslipper merged 1 commit intoethereum-optimism:developfrom
Conversation
cfromknecht
requested review from
mslipper,
optimisticben and
tynes
as code owners
🦋 Changeset detectedLatest commit: 75040ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| LOG_LEVEL=debug | ||
| BATCH_SUBMITTER_LOG_LEVEL=debug | ||
| BATCH_SUBMITTER_LOG_TERMINAL=true | ||
| BATCH_SUBMITTER_MIN_L1_TX_SIZE=32 |
There was a problem hiding this comment.
and it also includes the function selector
There was a problem hiding this comment.
Maybe include the unit with the config option, like metrics?
BATCH_SUBMITTER_MIN_L1_TX_BYTES
BATCH_SUBMITTER_POLL_INTERVAL_MS
There was a problem hiding this comment.
the poll interval is a duration flag meaning you can do 10s for 10 seconds and it will be parsed without a problem
|
Do you mind adding a logline that logs the min and max tx sizes at startup? |
Codecov Report
@@ Coverage Diff @@
## develop #2289 +/- ##
========================================
Coverage 80.08% 80.08%
========================================
Files 77 77
Lines 2460 2460
Branches 450 450
========================================
Hits 1970 1970
Misses 490 490
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
cfromknecht
force-pushed
the
bss-min-tx-size
branch
from
8f7be73 to
75040ca
Compare
6 participants
Description
Adds a
MIN_L1_TX_SIZEconfiguration for controlling the minimum tx batch size.Metadata