Skip to content

feat: extract gas limit estimation to driver, add 20% buffer#2291

Merged
mslipper merged 1 commit intoethereum-optimism:developfrom
cfromknecht:bss-gas-estimation-limit
Mar 9, 2022
Merged

feat: extract gas limit estimation to driver, add 20% buffer#2291
mslipper merged 1 commit intoethereum-optimism:developfrom
cfromknecht:bss-gas-estimation-limit

Conversation

@cfromknecht
Copy link
Contributor

@cfromknecht cfromknecht commented Mar 8, 2022

Description
On mainnet we are seeing out of gas exceptions with some frequency. In all
of these cases it appears we are very, very close to being successful.
This commit extracts the internal calls performed by RawTransact into
the driver and then adds a buffer to limit the possibility of losing
money on the reverting transactions, since these very large transactions
are costly especially in the current fee market.

Metadata

  • Fixes ENG-2046

@cfromknecht cfromknecht requested a review from tynes as a code owner March 8, 2022 19:32
@changeset-bot
Copy link

changeset-bot bot commented Mar 8, 2022

🦋 Changeset detected

Latest commit: aca0684

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/batch-submitter-service Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cfromknecht cfromknecht force-pushed the bss-gas-estimation-limit branch from 3a91cc6 to 2282622 Compare March 8, 2022 19:34
@tynes
Copy link
Contributor

tynes commented Mar 8, 2022

Do you mind adding a changeset? Otherwise looks good to me

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2022

Codecov Report

Merging #2291 (3277883) into develop (42d02bc) will increase coverage by 16.07%.
The diff coverage is n/a.

❗ Current head 3277883 differs from pull request most recent head aca0684. Consider uploading reports for the commit aca0684 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2291       +/-   ##
============================================
+ Coverage    80.08%   96.15%   +16.07%     
============================================
  Files           77       51       -26     
  Lines         2460     1508      -952     
  Branches       450      229      -221     
============================================
- Hits          1970     1450      -520     
+ Misses         490       58      -432     
Flag Coverage Δ
contracts 99.29% <ø> (ø)
core-utils 86.77% <ø> (ø)
data-transport-layer ?
sdk ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/sdk/src/index.ts
packages/sdk/src/interfaces/types.ts
packages/data-transport-layer/src/utils/index.ts
packages/sdk/src/utils/contracts.ts
...layer/src/services/l1-ingestion/handlers/errors.ts
packages/sdk/src/adapters/eth-bridge.ts
packages/sdk/src/utils/index.ts
packages/sdk/src/adapters/dai-bridge.ts
...ckages/data-transport-layer/src/utils/contracts.ts
packages/sdk/src/utils/misc-utils.ts
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42d02bc...aca0684. Read the comment docs.

@cfromknecht cfromknecht force-pushed the bss-gas-estimation-limit branch 2 times, most recently from a50031f to 3277883 Compare March 8, 2022 23:24
On mainnet we are seeing out of exceptions with some frequency. In all
of these cases it appears we are very, very close to being successful.
This commit extracts the internal calls performed by RawTransact into
the driver and then adds a buffer to limit the possibility of losing
money on the reverting transactions, since these very large transactions
are costly especially in the current fee market.
@cfromknecht cfromknecht force-pushed the bss-gas-estimation-limit branch from 3277883 to aca0684 Compare March 8, 2022 23:26
@mslipper mslipper merged commit 5c83435 into ethereum-optimism:develop Mar 9, 2022
@cfromknecht cfromknecht deleted the bss-gas-estimation-limit branch March 9, 2022 17:18
theochap pushed a commit that referenced this pull request Dec 10, 2025
### Description

Updates the kona book with the indexed and polling traversal stages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants