proxyd: Don't hit Redis when the out of service interval is zero#2302
Merged
mslipper merged 1 commit intoethereum-optimism:developfrom Mar 10, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: ae18cea The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
When the out of service interval is zero, `proxyd` will send a `SETEX` command to Redis with a zero expiry. This is technically an error, and causes messages like `error setting backend unavailable ERR invalid expire time in setex` to appear in the logs. Users won't notice the issue since `proxyd` can continue working when Redis returns an error, but we should clean this up nonetheless since these problems appear in our alerting.
mslipper
force-pushed
the
bugfix/proxyd-zero-oos-interval
branch
from
2c05d02 to
ae18cea
Compare
Inphi
approved these changes
Mar 9, 2022
Codecov Report
@@ Coverage Diff @@
## develop #2302 +/- ##
========================================
Coverage 80.08% 80.08%
========================================
Files 77 77
Lines 2460 2460
Branches 450 450
========================================
Hits 1970 1970
Misses 490 490
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
tynes
approved these changes
Mar 10, 2022
theochap
added a commit
that referenced
this pull request
Dec 10, 2025
## Description Small PR to refactor the process method out of the engine actor. See op-rs/kona#2271 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the out of service interval is zero,
proxydwill send aSETEXcommand to Redis with a zero expiry. This is technically an error, and causes messages likeerror setting backend unavailable ERR invalid expire time in setexto appear in the logs. Users won't notice the issue sinceproxydcan continue working when Redis returns an error, but we should clean this up nonetheless since these problems appear in our alerting.