Skip to content

ops: Build cleanups#2283

Merged
mslipper merged 1 commit intoethereum-optimism:developfrom
mslipper:feat/build-updates
Mar 8, 2022
Merged

ops: Build cleanups#2283
mslipper merged 1 commit intoethereum-optimism:developfrom
mslipper:feat/build-updates

Conversation

@mslipper
Copy link
Collaborator

@mslipper mslipper commented Mar 8, 2022

Cleans up a bunch of configuration in ops/, in preparation for switching most of our build configuration to CircleCI. Changes include:

  1. Removing the "builder image" concept in favor of a single multi-target Dockerfile. Once this goes live on CircleCI, we'll be able to leverage Docker Layer caching more effectively.
  2. Fixes the nightly build, which is currently failing on the legacy batch submitter.
  3. Removes the legacy rpc-proxy since it isn't used anywhere anymore.
  4. Re-enables CODEOWNERS.
  5. Removes the docker-compose-nobuild.yml file, since the main docker-compose.yml file now supports images and builds.

Meta:

  • Fixes ENG-1838

@changeset-bot
Copy link

changeset-bot bot commented Mar 8, 2022

⚠️ No Changeset found

Latest commit: 0fb3050

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mslipper mslipper requested a review from tynes March 8, 2022 00:12
@github-actions github-actions bot added 2-reviewers M-ci Meta: ci related work A-ops Area: ops labels Mar 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2022

Codecov Report

Merging #2283 (0fb3050) into develop (67146ed) will increase coverage by 16.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2283       +/-   ##
============================================
+ Coverage    80.08%   96.15%   +16.07%     
============================================
  Files           77       51       -26     
  Lines         2460     1508      -952     
  Branches       450      229      -221     
============================================
- Hits          1970     1450      -520     
+ Misses         490       58      -432     
Flag Coverage Δ
contracts 99.29% <ø> (ø)
core-utils 86.77% <ø> (ø)
data-transport-layer ?
sdk ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/sdk/src/utils/index.ts
packages/sdk/src/interfaces/types.ts
packages/sdk/src/utils/chain-constants.ts
...ices/l1-ingestion/handlers/transaction-enqueued.ts
packages/sdk/src/adapters/dai-bridge.ts
packages/sdk/src/interfaces/index.ts
packages/sdk/hardhat.config.ts
...ckages/data-transport-layer/src/utils/contracts.ts
packages/sdk/src/cross-chain-messenger.ts
packages/sdk/src/utils/message-encoding.ts
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67146ed...0fb3050. Read the comment docs.

@mslipper mslipper force-pushed the feat/build-updates branch 2 times, most recently from b1d58ae to e3be1fb Compare March 8, 2022 00:35
@tynes
Copy link
Contributor

tynes commented Mar 8, 2022

Since the builder is being removed, the concept of builder can be taken out of ops/scripts/ci-versions.js

@tynes
Copy link
Contributor

tynes commented Mar 8, 2022

Can confirm that a simple docker-compose build works for building the images. We should make sure that the docs are updated accordingly

@mslipper mslipper force-pushed the feat/build-updates branch from e3be1fb to b7510ce Compare March 8, 2022 02:13
@mslipper
Copy link
Collaborator Author

mslipper commented Mar 8, 2022

Cool! Updated to fix ci-versions.js.

@tynes
Copy link
Contributor

tynes commented Mar 8, 2022

Also confirming that docker-compose pull works

Cleans up a bunch of configuration in `ops/`, in preparation for switching most of our build configuration to CircleCI. Changes include:

1. Removing the "builder image" concept in favor of a single multi-target Dockerfile. Once this goes live on CircleCI, we'll be able to leverage Docker Layer caching more effectively.
2. Fixes the nightly build, which is currently failing on the legacy batch submitter.
3. Removes the legacy rpc-proxy since it isn't used anywhere anymore.
4. Re-enables CODEOWNERS.
5. Removes the `docker-compose-nobuild.yml` file, since the main `docker-compose.yml` file now supports images and builds.

Meta:

- Fixes ENG-1838
@mslipper mslipper force-pushed the feat/build-updates branch from b7510ce to 0fb3050 Compare March 8, 2022 02:18
@mslipper mslipper merged commit a68097c into ethereum-optimism:develop Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ops Area: ops M-ci Meta: ci related work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants