Skip to content

feat: L1 fee + base fee vault predeploys#3825

Merged
mslipper merged 18 commits intodevelopfrom
feat/hardcode-fee-addr-2
Nov 3, 2022
Merged

feat: L1 fee + base fee vault predeploys#3825
mslipper merged 18 commits intodevelopfrom
feat/hardcode-fee-addr-2

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented Oct 31, 2022 •
edited
Loading

Description

Adds 2 new predeploy addresses that become protocol constants. The L1 portion of the fee will be paid out to a particular predeploy and the basefee will be paid out to a particular predeploy instead of being burnt. This allows for the way that the fees are handled to be moved to the application layer, these contracts can be upgraded after the fact with alternative logic. Right now they are simple implementations of the way that the SequencerFeeVault works already

This PR is large because all of the changes in op-bindings

A companion PR can be found here: ethereum-optimism/op-geth#23
Once this is merged into op-geth and the latest commit is added as a dep here, then we can further reduce config

@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6a0671c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 2-reviewers A-pkg-contracts-bedrock Area: packages/contracts-bedrock labels Oct 31, 2022
@mergify
Copy link
Contributor

mergify bot commented Oct 31, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@mergify
Copy link
Contributor

mergify bot commented Nov 1, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Nov 1, 2022
@tynes tynes force-pushed the feat/hardcode-fee-addr-2 branch from 823a0f0 to 0388c42 Compare November 1, 2022 19:33
@mergify mergify bot removed the conflict label Nov 1, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 1, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Nov 1, 2022
@tynes tynes force-pushed the feat/hardcode-fee-addr-2 branch from 47f85dd to 4d44c74 Compare November 1, 2022 22:08
@mergify mergify bot removed the conflict label Nov 1, 2022
@tynes
Copy link
Contributor Author

tynes commented Nov 1, 2022

On the deployed contracts devnet

Error: expected 1 message, got 0
    at CrossChainMessenger.toCrossChainMessage (/home/circleci/project/packages/sdk/src/cross-chain-messenger.ts:517:15)

tynes
tynes commented Nov 1, 2022
View reviewed changes
tynes
tynes commented Nov 1, 2022
View reviewed changes
tynes
tynes commented Nov 1, 2022
View reviewed changes
@tynes tynes marked this pull request as ready for review November 1, 2022 23:45
maurelian
maurelian reviewed Nov 2, 2022
View reviewed changes
maurelian
maurelian reviewed Nov 2, 2022
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Nov 2, 2022
@tynes
Copy link
Contributor Author

tynes commented Nov 2, 2022

Need to regenerate the more files

@tynes tynes force-pushed the feat/hardcode-fee-addr-2 branch from 9c8f514 to c157971 Compare November 3, 2022 00:43
@tynes
Copy link
Contributor Author

tynes commented Nov 3, 2022

I've addressed all feedback on this PR @maurelian @smartcontracts

@mergify mergify bot removed the conflict label Nov 3, 2022
maurelian
maurelian approved these changes Nov 3, 2022
View reviewed changes
@mslipper mslipper merged commit 8428a2c into develop Nov 3, 2022
@mslipper mslipper deleted the feat/hardcode-fee-addr-2 branch November 3, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maurelian maurelian maurelian approved these changes

@smartcontracts smartcontracts Awaiting requested review from smartcontracts

@clabby clabby Awaiting requested review from clabby

+1 more reviewer

@mslipper mslipper mslipper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-pkg-contracts-bedrock Area: packages/contracts-bedrock

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tynes @mslipper @maurelian