optimism: user can set pending block gas limit#24
Merged
protolambda merged 1 commit intooptimism-historyfrom Dec 16, 2022
Merged
optimism: user can set pending block gas limit#24protolambda merged 1 commit intooptimism-historyfrom
protolambda merged 1 commit intooptimism-historyfrom
Conversation
protolambda
force-pushed
the
pending-gas-limit
branch
from
d202139 to
98b5859
Compare
protolambda
changed the base branch from
dynamic-gas-limit
to
optimism-history
protolambda
force-pushed
the
pending-gas-limit
branch
from
98b5859 to
4146e94
Compare
protolambda
force-pushed
the
pending-gas-limit
branch
from
4146e94 to
c69b1f1
Compare
tynes
reviewed
Dec 15, 2022
tynes
approved these changes
Dec 16, 2022
chokobole
pushed a commit
to kroma-network/go-ethereum
that referenced
this pull request
Feb 6, 2023
chokobole
pushed a commit
to kroma-network/go-ethereum
that referenced
this pull request
Feb 6, 2023
chokobole
pushed a commit
to kroma-network/go-ethereum
that referenced
this pull request
Feb 6, 2023
protolambda
added a commit
that referenced
this pull request
Feb 22, 2023
joey0612
pushed a commit
to joey0612/op-geth
that referenced
this pull request
Feb 20, 2024
snap: fix snap-tests to handle legacy code lookups
zhiqiangxu
referenced
this pull request
in ethstorage/op-geth
Jul 18, 2024
* w3ip-02 test: withdraw code staking * check suicide post state * minor * add compilation info
kangsorang
pushed a commit
to kroma-network/7560-geth
that referenced
this pull request
Oct 15, 2024
blockchaindevsh
added a commit
to blockchaindevsh/op-geth
that referenced
this pull request
Jan 25, 2025
…timism#24) * make `GetBalance` return the sum of native & sgt balance * add another http listener for sgt
blockchaindevsh
added a commit
to blockchaindevsh/op-geth
that referenced
this pull request
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the pending block is computed, it would previously use the full gas limit. When the eip 1559 elasticity is high, this can be too much gas for some resource constrained devices. And every tx processed into the pending block is re-applied if it's not included. This can cause high block production lag as seen in opcraft. To mitigate this, we can allow the user to set the pending gas limit with the existing miner gas limit flag, which is non-functional in optimism otherwise, since the gas limit is set by the system configuration.
The
prepareWorkmethod has two call paths:This depends on #22DoneTests
e2e testing of pending gas limit: ethereum-optimism/optimism#4047
Metadata
Fix ENG-2978