Skip to content

Rename sequencer flag from http to rpc#11

Closed
maurelian wants to merge 1 commit intooptimism-historyfrom
rename-RollupSequencerHTTP-flag
Closed

Rename sequencer flag from http to rpc#11
maurelian wants to merge 1 commit intooptimism-historyfrom
rename-RollupSequencerHTTP-flag

Conversation

@maurelian
Copy link
Copy Markdown
Contributor

Description

Addresses the comment on PR #10

Can we remove "http" from the name? Maybe just name it RPC?
The same holds for the old RollupSequencerHTTPFlag which slipped through; websockets and IPC are valid too, it's not always http.

@maurelian maurelian marked this pull request as ready for review October 17, 2022 17:13
Copy link
Copy Markdown
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Need to target optimism-history branch though.

@trianglesphere
Copy link
Copy Markdown
Contributor

@protolambda this is going to need a bunch of updates across our deploys + in docs + maybe with partners

@mslipper
Copy link
Copy Markdown
Contributor

+1 on Josh - can we rename the old flag later? We'll have to get replica operators to update it as well, so there's a bunch of implied coordination overhead here to perform this rename.

@maurelian maurelian force-pushed the rename-RollupSequencerHTTP-flag branch from 9823ac1 to 6c7a087 Compare October 18, 2022 15:59
@maurelian maurelian changed the base branch from optimism to optimism-history October 18, 2022 15:59
@maurelian
Copy link
Copy Markdown
Contributor Author

+1 on Josh - can we rename the old flag later? We'll have to get replica operators to update it as well, so there's a bunch of implied coordination overhead here to perform this rename.

Closing this. 😅

@maurelian maurelian closed this Oct 18, 2022
joey0612 pushed a commit to joey0612/op-geth that referenced this pull request Feb 20, 2024
kangsorang pushed a commit to kroma-network/7560-geth that referenced this pull request Oct 15, 2024
* WIP: bring in old 4337 Bundler Collector Tracer code (compiles)

* Fix runtime errors (WIP)

* Adding missing fields, using OnEnter hook

* Fix using [0:20] bytes of "PaymasterData" instead of the new "Paymaster" field

* Fix banned opcode checks for Factory frame

* Add 'nil' check

---------

Co-authored-by: shahafn <shahaflol@gmail.com>
blockchaindevsh added a commit to blockchaindevsh/op-geth that referenced this pull request Apr 28, 2025
* update es-fork.yaml

* es-fork.yaml -> qkc-fork.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants