Skip to content

[KQL] Fixed styles of KQL textarea for the K8 theme#96190

Merged
cchaos merged 2 commits intoelastic:masterfrom
cchaos:k8/fix-kql
Apr 5, 2021
Merged

[KQL] Fixed styles of KQL textarea for the K8 theme#96190
cchaos merged 2 commits intoelastic:masterfrom
cchaos:k8/fix-kql

Conversation

@cchaos
Copy link
Contributor

@cchaos cchaos commented Apr 3, 2021

As well as some general heights and borders for both themes.

image

image

@cchaos cchaos added release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Apr 3, 2021
@cchaos cchaos requested a review from a team as a code owner April 3, 2021 21:29
@cchaos cchaos added the Feature:KQL KQL label Apr 3, 2021
@cchaos cchaos requested a review from a team as a code owner April 4, 2021 22:09
@cchaos
Copy link
Contributor Author

cchaos commented Apr 4, 2021

I have also pushed a fix for all the popover title/footer paddings associated with the KQL/Filter bar.

image

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
data 176.1KB 176.2KB +61.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 783.1KB 783.3KB +180.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled down, checked locally, and looked through code.

@cchaos
Copy link
Contributor Author

cchaos commented Apr 5, 2021

Thank you, both!

@cchaos cchaos merged commit 76acef0 into elastic:master Apr 5, 2021
@cchaos cchaos deleted the k8/fix-kql branch April 5, 2021 13:09
cchaos added a commit that referenced this pull request Apr 5, 2021
* Fixed style of KQL textarea for K8 theme and some general heights and borders

* Fix popover paddings
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 6, 2021
…-nav

* 'master' of github.com:elastic/kibana: (106 commits)
  [Lens] don't use eui variables for zindex (elastic#96117)
  Remove /src/legacy (elastic#95510)
  skip flaky suite (elastic#95899)
  [Dashboard] Fix Lens and TSVB chart tooltip positioning relative to global headers (elastic#94247)
  fixes a skipped management x-pack test (elastic#96178)
  [App Search] API logs: Add log detail flyout (elastic#96162)
  [tech-debt] Remove defunct opacity parameters from EUI shadow functions (elastic#96191)
  Add Input Controls project configuration (elastic#96238)
  [file upload] document file upload privileges and provide actionable UI when failures occur (elastic#95883)
  Revert "TS Incremental build exclude test files (elastic#95610)" (elastic#96223)
  [App Search] Added Sample Response section to Result Settings (elastic#95971)
  [Maps] Safe-erase text-field (elastic#94873)
  [RAC][Alert Triage][TGrid] Update the Alerts Table (TGrid) API to implement `renderCellValue` (elastic#96098)
  [Maps] Enable all zoom levels for all users (elastic#96093)
  Use plugin version in its publicPath (elastic#95945)
  [Enterprise Search] Expose core.chrome.setIsVisible for use in Workplace Search (elastic#95984)
  [Workplace Search] Add sub nav and fix rendering bugs in Personal dashboard (elastic#96100)
  [OBS]home page is showing incorrect value of APM throughput (tpm) (elastic#95991)
  [Observability] Exploratory View initial skeleton (elastic#94426)
  [KQL] Fixed styles of KQL textarea for the K8 theme (elastic#96190)
  ...

# Conflicts:
#	x-pack/plugins/snapshot_restore/__jest__/client_integration/helpers/restore_snapshot.helpers.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:KQL KQL release_note:skip Skip the PR/issue when compiling release notes v7.13.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants