[Maps] Enable all zoom levels for all users#96093
Merged
thomasneirynck merged 11 commits intoelastic:masterfrom Apr 5, 2021
Merged
[Maps] Enable all zoom levels for all users#96093thomasneirynck merged 11 commits intoelastic:masterfrom
thomasneirynck merged 11 commits intoelastic:masterfrom
Conversation
thomasneirynck
added
release_note:enhancement
Team:Geo
Contributor
|
tile server |
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
tylersmalley
approved these changes
Apr 2, 2021
Member
tylersmalley
left a comment
tylersmalley
left a comment
There was a problem hiding this comment.
Limits change LGTM, especially when it means getting rid of things!
nickpeihl
approved these changes
Apr 2, 2021
Contributor
nickpeihl
left a comment
nickpeihl
left a comment
There was a problem hiding this comment.
lgtm!
tested in Firefox and code review
| }); | ||
| // any kibana user, regardless of distribution, should get all zoom levels | ||
| // use `sspl` license to indicate this | ||
| this._emsClient.addQueryParams({ license: 'sspl' }); |
Contributor
There was a problem hiding this comment.
Maybe out of scope for this PR, but should we consider adding a license parameter to the EMSClient constructor in the @elastic/ems-client library?
Contributor
Author
There was a problem hiding this comment.
yes, let's do that in separate, since it requires upstream change. I can create a separate PR for the ems-client for this.
jbudz
approved these changes
Apr 3, 2021
Contributor
Author
|
@elasticmachine merge upstream |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Apr 5, 2021
# Conflicts: # .github/CODEOWNERS
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
thomasneirynck
added a commit
that referenced
this pull request
Apr 5, 2021
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Apr 6, 2021
…-nav * 'master' of github.com:elastic/kibana: (106 commits) [Lens] don't use eui variables for zindex (elastic#96117) Remove /src/legacy (elastic#95510) skip flaky suite (elastic#95899) [Dashboard] Fix Lens and TSVB chart tooltip positioning relative to global headers (elastic#94247) fixes a skipped management x-pack test (elastic#96178) [App Search] API logs: Add log detail flyout (elastic#96162) [tech-debt] Remove defunct opacity parameters from EUI shadow functions (elastic#96191) Add Input Controls project configuration (elastic#96238) [file upload] document file upload privileges and provide actionable UI when failures occur (elastic#95883) Revert "TS Incremental build exclude test files (elastic#95610)" (elastic#96223) [App Search] Added Sample Response section to Result Settings (elastic#95971) [Maps] Safe-erase text-field (elastic#94873) [RAC][Alert Triage][TGrid] Update the Alerts Table (TGrid) API to implement `renderCellValue` (elastic#96098) [Maps] Enable all zoom levels for all users (elastic#96093) Use plugin version in its publicPath (elastic#95945) [Enterprise Search] Expose core.chrome.setIsVisible for use in Workplace Search (elastic#95984) [Workplace Search] Add sub nav and fix rendering bugs in Personal dashboard (elastic#96100) [OBS]home page is showing incorrect value of APM throughput (tpm) (elastic#95991) [Observability] Exploratory View initial skeleton (elastic#94426) [KQL] Fixed styles of KQL textarea for the K8 theme (elastic#96190) ... # Conflicts: # x-pack/plugins/snapshot_restore/__jest__/client_integration/helpers/restore_snapshot.helpers.ts
rashmivkulkarni
added
release_note:skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables all EMS zoom levels for all users. Do this by default by setting
license=ssplin the request for the old OSS visualizations (region, coordinate, and vega).In practice, with this PR, Kibana-requests to EMS follow this approach:
license=sspl, regardless of distribution. Users of these visualizations will get all zoom levels, regardless of distribution.Apart from the end-user benefits, there are some internal benefits:
mapsLicensingPlugin. Because of this,mapsEms-plugin does not need to be loaded on page-load, cutting out all the unnecessary ems-loading. This will likely fix [Maps] maps_legacy async bundle is loaded on startup #92664.setQueryParamsAPI method fromServiceSettings, as license-injection by x-pack code is no longer necessary.This also sets us up for other simplifciations:
ServiceSettingsdependency from VegaMaps, and instead use theEMSSettingsdirectly, enabling on-prem.For maintainers