Remove /src/legacy by pgayvallet · Pull Request #95510 · elastic/kibana

pgayvallet · 2021-03-26T12:30:23Z

Summary

Part of #94141
closes #81483

Get rid of /src/legacy

Move the legacy logging registration to core's legacy service
Move the remaining '/{path*}' route to core's app service
Add the legacy logging schema to core's logging config
Remove last utils from src/core/server/utils (fromRoot and pkg), replaced by using @kbn/utils instead
Adapt and fix stuff

Checklist

Unit or functional tests were updated or added to match the most common scenarios

Release Note

The plugins.scanDirs configuration property has been deprecated and is no longer used.
The server.maxPayloadBytes configuration property has been renamed server.maxPayload

kibanamachine · 2021-03-26T14:32:35Z

⏳ Build in-progress, with failures

continuous-integration/kibana-ci/pull-request
Commit: 3427c1a
Storybooks not built yet
This comment will update when the build is complete

Failed CI Steps

History

💔 Build #115465 failed dac4ac0
💔 Build #115451 failed 264e77c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…nal-countdown

kibanamachine · 2021-03-29T11:33:58Z

⏳ Build in-progress, with failures

continuous-integration/kibana-ci/pull-request
Commit: 9628609
Storybooks not built yet
This comment will update when the build is complete

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…nal-countdown

kibanamachine · 2021-03-30T14:40:51Z

⏳ Build in-progress, with failures

continuous-integration/kibana-ci/pull-request
Commit: 8d5cadf
Storybooks not built yet
This comment will update when the build is complete

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2021-03-30T15:09:32Z

⏳ Build in-progress, with failures

continuous-integration/kibana-ci/pull-request
Commit: 871e4c3
Storybooks not built yet
This comment will update when the build is complete

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2021-03-30T15:23:53Z

⏳ Build in-progress, with failures

continuous-integration/kibana-ci/pull-request
Commit: dd02cfa
Storybooks not built yet
This comment will update when the build is complete

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…nal-countdown

kibanamachine · 2021-03-30T19:04:25Z

⏳ Build in-progress, with failures

continuous-integration/kibana-ci/pull-request
Commit: 3443fa1
Storybooks not built yet
This comment will update when the build is complete

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mshustov · 2021-03-31T17:45:50Z

ack: will review tomorrow

packages/kbn-utils/src/package_json/index.ts

src/core/server/config/ensure_valid_configuration.test.ts

src/core/server/core_app/integration_tests/core_app_routes.test.ts

mshustov · 2021-04-01T13:57:24Z

src/core/server/legacy/legacy_service.ts

+    const currentOpsConfig = await this.opsConfig$.pipe(first()).toPromise();

-    this.log.debug('starting legacy service');
+    await setupLogging(server, legacyLoggingConfig, currentOpsConfig.interval.asMilliseconds());


Nit: ops config is not used

kibana/packages/kbn-legacy-logging/src/get_logging_config.ts

Line 35 in 72670eb

ops: '!',

It's up to you whether remove it not or in v8.0

It's still possible to use the legacy ops metrics by manually specifying logging.events.ops: "*", so I think we need to keep it until 8.0

mshustov · 2021-04-01T14:23:30Z

src/core/server/config/ensure_valid_configuration.ts

-    settings,
-    legacyConfig,
-  });
+export async function ensureValidConfiguration(configService: ConfigService) {


Should we convert it into a method of ConfigService? It's odd that server imports it from /config and passes ConfigService as an argument.

mshustov · 2021-04-01T14:27:14Z

src/core/server/ui_settings/integration_tests/index.test.ts

  describe('doc missing', docMissingSuite(savedObjectIndex));
-  describe('doc missing and index readonly', docMissingAndIndexReadOnlySuite(savedObjectIndex));
  describe('doc exists', docExistsSuite(savedObjectIndex));


If everything is covered in api-integration tests, let's remove these tests

src/core/server/ui_settings/integration_tests/lib/servers.ts

src/core/server/utils/index.ts

mshustov · 2021-04-01T14:39:32Z

x-pack/plugins/ml/server/lib/spaces_utils.ts

-export type RequestFacade = KibanaRequest | Legacy.Request;
-
 export function spacesUtilsProvider(
  getSpacesPlugin: (() => Promise<SpacesPluginStart>) | undefined,
-  request: RequestFacade
+  request: KibanaRequest


Thanks. we can take care of others in #77997

legrego

Changes to skipped spaces tests lgtm

src/core/server/logging/logging_config.ts

darnautov

ML changes LGTM

…nal-countdown

kibanamachine · 2021-04-05T21:43:08Z

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

💚 Build #117292 succeeded 4541ab1
💔 Build #117269 failed 69a9d8c
💔 Build #117289 failed af6c32d
💔 Build #117285 failed 436e094
💔 Build #116812 failed 89bf3d6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* starting removing stuff * fix jest config * disable CLI mode until other PR is merged * fix the schema * add deprecation for maxPayloadBytes * fix legacy start logic * deletes `env` from unknown args * fix FTR test config * some legacy service deletion * move config validation * remove legacy exports from entrypoint * preserve legacy logging in core logging config * try to fix uiSettings integration tests * fix legacy service tests * more type fix * use fromRoot from @kbn/utils * cleanup kibana.d.ts * fix unit tests * remove src/core/server/utils * fix server script * add integration test for `/{path*}` route * add unit tests on legacy config * adapt uiSetting IT bis * fix tests * update generated doc * address some review comments * move review comments * fix some stuff * fix some stuff * fix some stuff * fix some stuff bis * generated doc * add test for ensureValidConfiguration # Conflicts: # .github/CODEOWNERS # src/cli_plugin/install/core_plugins/kibana/public/context/query_parameters/state.js # src/core/server/http/http_config.ts # x-pack/test/functional/config.js

…-nav * 'master' of github.com:elastic/kibana: (106 commits) [Lens] don't use eui variables for zindex (elastic#96117) Remove /src/legacy (elastic#95510) skip flaky suite (elastic#95899) [Dashboard] Fix Lens and TSVB chart tooltip positioning relative to global headers (elastic#94247) fixes a skipped management x-pack test (elastic#96178) [App Search] API logs: Add log detail flyout (elastic#96162) [tech-debt] Remove defunct opacity parameters from EUI shadow functions (elastic#96191) Add Input Controls project configuration (elastic#96238) [file upload] document file upload privileges and provide actionable UI when failures occur (elastic#95883) Revert "TS Incremental build exclude test files (elastic#95610)" (elastic#96223) [App Search] Added Sample Response section to Result Settings (elastic#95971) [Maps] Safe-erase text-field (elastic#94873) [RAC][Alert Triage][TGrid] Update the Alerts Table (TGrid) API to implement `renderCellValue` (elastic#96098) [Maps] Enable all zoom levels for all users (elastic#96093) Use plugin version in its publicPath (elastic#95945) [Enterprise Search] Expose core.chrome.setIsVisible for use in Workplace Search (elastic#95984) [Workplace Search] Add sub nav and fix rendering bugs in Personal dashboard (elastic#96100) [OBS]home page is showing incorrect value of APM throughput (tpm) (elastic#95991) [Observability] Exploratory View initial skeleton (elastic#94426) [KQL] Fixed styles of KQL textarea for the K8 theme (elastic#96190) ... # Conflicts: # x-pack/plugins/snapshot_restore/__jest__/client_integration/helpers/restore_snapshot.helpers.ts

* Remove /src/legacy (#95510) * starting removing stuff * fix jest config * disable CLI mode until other PR is merged * fix the schema * add deprecation for maxPayloadBytes * fix legacy start logic * deletes `env` from unknown args * fix FTR test config * some legacy service deletion * move config validation * remove legacy exports from entrypoint * preserve legacy logging in core logging config * try to fix uiSettings integration tests * fix legacy service tests * more type fix * use fromRoot from @kbn/utils * cleanup kibana.d.ts * fix unit tests * remove src/core/server/utils * fix server script * add integration test for `/{path*}` route * add unit tests on legacy config * adapt uiSetting IT bis * fix tests * update generated doc * address some review comments * move review comments * fix some stuff * fix some stuff * fix some stuff * fix some stuff bis * generated doc * add test for ensureValidConfiguration # Conflicts: # .github/CODEOWNERS # src/cli_plugin/install/core_plugins/kibana/public/context/query_parameters/state.js # src/core/server/http/http_config.ts # x-pack/test/functional/config.js * codestyle

This reverts commit 251bd9a.

pgayvallet added 4 commits March 26, 2021 13:29

starting removing stuff

264e77c

fix jest config

60effbc

disable CLI mode until other PR is merged

dac4ac0

fix the schema

3427c1a

pgayvallet added 5 commits March 29, 2021 11:06

Merge remote-tracking branch 'upstream/master' into kbn-xxx-legacy-fi…

cff9b0b

…nal-countdown

add deprecation for maxPayloadBytes

46260c8

fix legacy start logic

5a9ff60

deletes env from unknown args

4a9bd3a

fix FTR test config

9628609

pgayvallet added 2 commits March 30, 2021 16:12

Merge remote-tracking branch 'upstream/master' into kbn-xxx-legacy-fi…

510caae

…nal-countdown

some legacy service deletion

8d5cadf

move config validation

7daef0a

pgayvallet added Feature:Legacy Removal Issues related to removing legacy Kibana release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.13.0 labels Mar 30, 2021

remove legacy exports from entrypoint

871e4c3

preserve legacy logging in core logging config

dd02cfa

pgayvallet added 3 commits March 30, 2021 20:26

try to fix uiSettings integration tests

5148dd4

fix legacy service tests

f4f9ad0

Merge remote-tracking branch 'upstream/master' into kbn-xxx-legacy-fi…

3443fa1

…nal-countdown

pgayvallet added 3 commits March 30, 2021 21:15

more type fix

c1eab04

use fromRoot from @kbn/utils

4b5df60

cleanup kibana.d.ts

fa8da2b

lizozom approved these changes Mar 31, 2021

View reviewed changes

mshustov approved these changes Apr 1, 2021

View reviewed changes

legrego approved these changes Apr 1, 2021

View reviewed changes

TinaHeiligers reviewed Apr 1, 2021

View reviewed changes

src/core/server/logging/logging_config.ts Show resolved Hide resolved

darnautov approved these changes Apr 2, 2021

View reviewed changes

pgayvallet added 4 commits April 5, 2021 16:03

Merge remote-tracking branch 'upstream/master' into kbn-xxx-legacy-fi…

315a8b2

…nal-countdown

address some review comments

69a9d8c

move review comments

04e90cc

Merge remote-tracking branch 'upstream/master' into kbn-xxx-legacy-fi…

436e094

…nal-countdown

pgayvallet added release_note:deprecation and removed release_note:skip Skip the PR/issue when compiling release notes labels Apr 5, 2021

pgayvallet added 7 commits April 5, 2021 18:48

fix some stuff

af6c32d

fix some stuff

a057a60

fix some stuff

a49f2e1

fix some stuff bis

2445460

generated doc

4541ab1

add test for ensureValidConfiguration

d75d880

Merge remote-tracking branch 'upstream/master' into kbn-xxx-legacy-fi…

b16ebf3

…nal-countdown

pgayvallet merged commit 251bd9a into elastic:master Apr 6, 2021

pgayvallet mentioned this pull request Apr 6, 2021

[7.x] Remove /src/legacy (#95510) #96283

Merged

mistic added a commit to mistic/kibana that referenced this pull request Apr 6, 2021

Revert "Remove /src/legacy (elastic#95510)"

717d791

This reverts commit 251bd9a.

mistic mentioned this pull request Apr 6, 2021

Revert "Remove /src/legacy (#95510)" #96314

Closed

This was referenced Apr 6, 2021

notify main dev process when server is ready #96332

Merged

Fix config validation when elastic.apm is defined #96502

Merged

jportner mentioned this pull request Apr 14, 2021

Update docs and other usage of deprecated server.maxPayloadBytes config #97153

Closed

Conversation

pgayvallet commented Mar 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Release Note

Uh oh!

kibanamachine commented Mar 26, 2021

⏳ Build in-progress, with failures

Failed CI Steps

History

Uh oh!

kibanamachine commented Mar 29, 2021

⏳ Build in-progress, with failures

Failed CI Steps

History

Uh oh!

kibanamachine commented Mar 30, 2021

⏳ Build in-progress, with failures

Failed CI Steps

History

Uh oh!

kibanamachine commented Mar 30, 2021

⏳ Build in-progress, with failures

Failed CI Steps

History

Uh oh!

kibanamachine commented Mar 30, 2021

⏳ Build in-progress, with failures

Failed CI Steps

History

Uh oh!

kibanamachine commented Mar 30, 2021

⏳ Build in-progress, with failures

Failed CI Steps

History

Uh oh!

mshustov commented Mar 31, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mshustov Apr 1, 2021

Choose a reason for hiding this comment

Uh oh!

pgayvallet Apr 5, 2021

Choose a reason for hiding this comment

Uh oh!

mshustov Apr 1, 2021

Choose a reason for hiding this comment

Uh oh!

mshustov Apr 1, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mshustov Apr 1, 2021

Choose a reason for hiding this comment

Uh oh!

legrego left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

darnautov left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Apr 5, 2021

💚 Build Succeeded

Metrics [docs]

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

pgayvallet commented Mar 26, 2021 •

edited

Loading