[file upload] document file upload privileges and provide actionable UI when failures occur by nreese · Pull Request #95883 · elastic/kibana

nreese · 2021-03-31T00:07:00Z

Fixes #90235, #41885, and #41928

This PR documents the required privileges for geospatial file uploading.

To test, create a user that does not have all of the required privileges mentioned in the documentation.

View when user fails permissions check. Links to docs explaining the required permissions

View when index calls fail. Provides elasticsearch error reason to help user's understand why indexing failed.

Success view.

…UI when failures occur

elasticmachine · 2021-03-31T00:07:02Z

Pinging @elastic/kibana-gis (Team:Geo)

…rrors

elasticmachine · 2021-03-31T16:35:34Z

Pinging @elastic/kibana-docs (Team:Docs)

x-pack/plugins/file_upload/public/components/import_complete_view.tsx

docs/maps/import-geospatial-data.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

nreese · 2021-04-01T15:51:17Z

@elasticmachine merge upstream

x-pack/plugins/file_upload/public/components/import_complete_view.tsx

kindsun · 2021-04-01T17:28:48Z

x-pack/plugins/file_upload/public/components/json_upload_and_parse.tsx

+    //
+    // check permissions
+    //
+    const canImport = await hasImportPermission({


Should we short-circuit this if this.state.indexName isn't defined? Looks like it will still do the endpoint roundtrip even if it's an empty string

The button triggering import is only enabled when indexName is set so no need to check for empty string. Logic ensuring this is in _onIndexNameChange

docs/maps/import-geospatial-data.asciidoc

x-pack/plugins/file_upload/public/components/import_complete_view.tsx

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

nreese · 2021-04-05T13:46:21Z

@elasticmachine merge upstream

kibanamachine · 2021-04-05T15:43:50Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fileUpload`	786.5KB	788.7KB	+2.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	375.2KB	375.4KB	+144.0B
`fileUpload`	13.0KB	13.8KB	+813.0B
total			+957.0B

History

💚 Build #116843 succeeded 675acfe
💔 Build #116814 failed 3a19d65
💚 Build #116676 succeeded 7cc8b81
💚 Build #116579 succeeded f10c54c
💔 Build #116395 failed cd996b8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kindsun

lgtm! 🙇

code review

…UI when failures occur (elastic#95883) * [file upload] document file upload privileges and provide actionable UI when failures occur * doc link * call hasImportPermission * docs tweeks * tslint * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * review feedback * fix bullet list format * clean-up i18n ids * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * documenation review feedback * add period to last privilege bullet item Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…-nav * 'master' of github.com:elastic/kibana: (106 commits) [Lens] don't use eui variables for zindex (elastic#96117) Remove /src/legacy (elastic#95510) skip flaky suite (elastic#95899) [Dashboard] Fix Lens and TSVB chart tooltip positioning relative to global headers (elastic#94247) fixes a skipped management x-pack test (elastic#96178) [App Search] API logs: Add log detail flyout (elastic#96162) [tech-debt] Remove defunct opacity parameters from EUI shadow functions (elastic#96191) Add Input Controls project configuration (elastic#96238) [file upload] document file upload privileges and provide actionable UI when failures occur (elastic#95883) Revert "TS Incremental build exclude test files (elastic#95610)" (elastic#96223) [App Search] Added Sample Response section to Result Settings (elastic#95971) [Maps] Safe-erase text-field (elastic#94873) [RAC][Alert Triage][TGrid] Update the Alerts Table (TGrid) API to implement `renderCellValue` (elastic#96098) [Maps] Enable all zoom levels for all users (elastic#96093) Use plugin version in its publicPath (elastic#95945) [Enterprise Search] Expose core.chrome.setIsVisible for use in Workplace Search (elastic#95984) [Workplace Search] Add sub nav and fix rendering bugs in Personal dashboard (elastic#96100) [OBS]home page is showing incorrect value of APM throughput (tpm) (elastic#95991) [Observability] Exploratory View initial skeleton (elastic#94426) [KQL] Fixed styles of KQL textarea for the K8 theme (elastic#96190) ... # Conflicts: # x-pack/plugins/snapshot_restore/__jest__/client_integration/helpers/restore_snapshot.helpers.ts

kibanamachine · 2021-04-07T19:47:24Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

kibanamachine · 2021-04-08T19:50:16Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

…nable UI when failures occur (#95883) (#96252) * [file upload] document file upload privileges and provide actionable UI when failures occur (#95883) * [file upload] document file upload privileges and provide actionable UI when failures occur * doc link * call hasImportPermission * docs tweeks * tslint * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * review feedback * fix bullet list format * clean-up i18n ids * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * documenation review feedback * add period to last privilege bullet item Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

nreese added 4 commits March 30, 2021 14:08

[file upload] document file upload privileges and provide actionable …

c9bbebd

…UI when failures occur

doc link

0481fef

call hasImportPermission

6befa9d

docs tweeks

cd996b8

nreese added release_note:fix Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.13.0 labels Mar 31, 2021

nreese requested review from gchaps and kindsun March 31, 2021 00:07

nreese requested a review from a team as a code owner March 31, 2021 00:07

pgayvallet approved these changes Mar 31, 2021

View reviewed changes

nreese added 2 commits March 31, 2021 10:29

Merge branch 'master' of github.com:elastic/kibana into file_upload_e…

f854871

…rrors

tslint

f10c54c

nreese added the Team:Docs label Mar 31, 2021

gchaps reviewed Mar 31, 2021

View reviewed changes

nreese and others added 5 commits March 31, 2021 16:00

Update docs/maps/import-geospatial-data.asciidoc

4ce8ca2

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Update docs/maps/import-geospatial-data.asciidoc

4c4af32

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Update docs/maps/import-geospatial-data.asciidoc

39fef6d

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Update docs/maps/import-geospatial-data.asciidoc

9aaec81

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

review feedback

7cc8b81

nreese requested a review from gchaps March 31, 2021 22:13

fix bullet list format

3a19d65

Merge branch 'master' into file_upload_errors

675acfe

kindsun reviewed Apr 1, 2021

View reviewed changes

x-pack/plugins/file_upload/public/components/import_complete_view.tsx Outdated Show resolved Hide resolved

kindsun reviewed Apr 1, 2021

View reviewed changes

clean-up i18n ids

3968d65

nreese requested a review from kindsun April 1, 2021 18:25

gchaps approved these changes Apr 1, 2021

View reviewed changes

nreese and others added 3 commits April 1, 2021 13:23

Update docs/maps/import-geospatial-data.asciidoc

167b786

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

documenation review feedback

4e2c43e

add period to last privilege bullet item

eb888fa

Merge branch 'master' into file_upload_errors

1cd6ca0

kindsun approved these changes Apr 5, 2021

View reviewed changes

nreese merged commit 2eae096 into elastic:master Apr 5, 2021

This was referenced Apr 5, 2021

[Maps] Maps app needs to display better error message when user doesn't have index permissions #41885

Closed

[Maps] No pop up error shown when an user with limited roles tries to upload geoJSON vector map file - error is seen in console instead. #41928

Closed

nreese mentioned this pull request Apr 5, 2021

[7.x] [file upload] document file upload privileges and provide actionable UI when failures occur (#95883) #96252

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 7, 2021

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 8, 2021

Conversation

nreese commented Mar 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Mar 31, 2021

Uh oh!

elasticmachine commented Mar 31, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nreese commented Apr 1, 2021

Uh oh!

Uh oh!

kindsun Apr 1, 2021

Choose a reason for hiding this comment

Uh oh!

nreese Apr 1, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nreese commented Apr 5, 2021

Uh oh!

kibanamachine commented Apr 5, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

kindsun left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Apr 7, 2021

Uh oh!

kibanamachine commented Apr 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nreese commented Mar 31, 2021 •

edited

Loading