Skip to content

[tech-debt] Remove defunct opacity parameters from EUI shadow functions#96191

Merged
clintandrewhall merged 2 commits intoelastic:masterfrom
clintandrewhall:tech-debt/eui-shadows
Apr 5, 2021
Merged

[tech-debt] Remove defunct opacity parameters from EUI shadow functions#96191
clintandrewhall merged 2 commits intoelastic:masterfrom
clintandrewhall:tech-debt/eui-shadows

Conversation

@clintandrewhall
Copy link
Contributor

@clintandrewhall clintandrewhall commented Apr 4, 2021

Summary

Canvas is still using deprecated (and non-functional) opacity parameters from EUI functions (elastic/eui#3428). This results in some log spew.

Took a few minutes to examine and kill the deprecated usage in Canvas. The EUI code literally ignores the opacity var, but I took a screenshot of before and after all the same. :-)

Before
Screen Shot 2021-04-03 at 10 52 15 PM

After
Screen Shot 2021-04-03 at 10 52 39 PM

@clintandrewhall clintandrewhall requested a review from a team as a code owner April 4, 2021 03:59
@clintandrewhall clintandrewhall added Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v7.13.0 v8.0.0 labels Apr 4, 2021
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 4, 2021

Pinging @elastic/kibana-presentation (Team:Presentation)

@clintandrewhall clintandrewhall added the release_note:skip Skip the PR/issue when compiling release notes label Apr 4, 2021
@clintandrewhall clintandrewhall requested review from a team, cqliu1 and ryankeairns April 4, 2021 04:01
@clintandrewhall clintandrewhall added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 4, 2021
myasonik
myasonik approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryankeairns is out this week so you probably won't hear from him, but cleaning up tech debt is always good 👍

@clintandrewhall
Copy link
Contributor Author

clintandrewhall commented Apr 5, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 5, 2021

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@clintandrewhall clintandrewhall merged commit 5667435 into elastic:master Apr 5, 2021
@clintandrewhall clintandrewhall deleted the tech-debt/eui-shadows branch April 5, 2021 20:32
@kibanamachine kibanamachine mentioned this pull request Apr 5, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Apr 5, 2021
@clintandrewhall @kibanamachine
[tech-debt] Remove defunct opacity parameters from EUI shadow functio…
5663972 
…ns (elastic#96191)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 5, 2021

💚 Backport successful

✅ 7.x / #96256

This backport PR will be merged automatically after passing CI.

@clintandrewhall clintandrewhall mentioned this pull request Apr 5, 2021
Merged
clintandrewhall added a commit to clintandrewhall/kibana that referenced this pull request Apr 5, 2021
@clintandrewhall @kibanamachine
[tech-debt] Remove defunct opacity parameters from EUI shadow functio…
93f6cd4 
…ns (elastic#96191)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
clintandrewhall added a commit that referenced this pull request Apr 5, 2021
@clintandrewhall @kibanamachine
[tech-debt] Remove defunct opacity parameters from EUI shadow functio…
435cdc5 
…ns (#96191) (#96260)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 6, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into sr/fix-wizard…
97ee8a6 
…-nav

* 'master' of github.com:elastic/kibana: (106 commits)
  [Lens] don't use eui variables for zindex (elastic#96117)
  Remove /src/legacy (elastic#95510)
  skip flaky suite (elastic#95899)
  [Dashboard] Fix Lens and TSVB chart tooltip positioning relative to global headers (elastic#94247)
  fixes a skipped management x-pack test (elastic#96178)
  [App Search] API logs: Add log detail flyout (elastic#96162)
  [tech-debt] Remove defunct opacity parameters from EUI shadow functions (elastic#96191)
  Add Input Controls project configuration (elastic#96238)
  [file upload] document file upload privileges and provide actionable UI when failures occur (elastic#95883)
  Revert "TS Incremental build exclude test files (elastic#95610)" (elastic#96223)
  [App Search] Added Sample Response section to Result Settings (elastic#95971)
  [Maps] Safe-erase text-field (elastic#94873)
  [RAC][Alert Triage][TGrid] Update the Alerts Table (TGrid) API to implement `renderCellValue` (elastic#96098)
  [Maps] Enable all zoom levels for all users (elastic#96093)
  Use plugin version in its publicPath (elastic#95945)
  [Enterprise Search] Expose core.chrome.setIsVisible for use in Workplace Search (elastic#95984)
  [Workplace Search] Add sub nav and fix rendering bugs in Personal dashboard (elastic#96100)
  [OBS]home page is showing incorrect value of APM throughput (tpm) (elastic#95991)
  [Observability] Exploratory View initial skeleton (elastic#94426)
  [KQL] Fixed styles of KQL textarea for the K8 theme (elastic#96190)
  ...

# Conflicts:
#	x-pack/plugins/snapshot_restore/__jest__/client_integration/helpers/restore_snapshot.helpers.ts
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 7, 2021
@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 7, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 8, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

3 similar comments
@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 9, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 12, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 13, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine added a commit that referenced this pull request Apr 13, 2021
@kibanamachine @clintandrewhall
[tech-debt] Remove defunct opacity parameters from EUI shadow functio…
52d4c8d 
…ns (#96191) (#96256)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Clint Andrew Hall <clint.hall@elastic.co>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cqliu1 cqliu1 Awaiting requested review from cqliu1

@ryankeairns ryankeairns Awaiting requested review from ryankeairns

1 more reviewer

@myasonik myasonik myasonik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v7.13.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@clintandrewhall @elasticmachine @kibanamachine @myasonik