Skip to content

[K8] Continuing to fix the KQL bar styles#96264

Merged
cchaos merged 2 commits intoelastic:masterfrom
cchaos:k8/fix-kql-2
Apr 8, 2021
Merged

[K8] Continuing to fix the KQL bar styles#96264
cchaos merged 2 commits intoelastic:masterfrom
cchaos:k8/fix-kql-2

Conversation

@cchaos
Copy link
Contributor

@cchaos cchaos commented Apr 5, 2021

Follow up to #96190

Apparently, there are version of the bar that can exclude either the Save Search dropdown (prepend) or the Language selector (append) or both.

image

image

@cchaos cchaos added Feature:KQL KQL release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Apr 5, 2021
@cchaos cchaos requested review from a team as code owners April 5, 2021 21:37
Copy link
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't run it, but the code and screenshoots LGTM

@cchaos
Copy link
Contributor Author

cchaos commented Apr 8, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
data 176.7KB 177.1KB +338.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 785.6KB 786.5KB +920.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cchaos cchaos merged commit 8658ef4 into elastic:master Apr 8, 2021
@cchaos cchaos deleted the k8/fix-kql-2 branch June 9, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:KQL KQL release_note:skip Skip the PR/issue when compiling release notes v7.13.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants