Skip to content

[Maps] Safe-erase text-field#94873

Merged
thomasneirynck merged 12 commits intoelastic:masterfrom
thomasneirynck:maps/text_field_disable
Apr 5, 2021
Merged

[Maps] Safe-erase text-field#94873
thomasneirynck merged 12 commits intoelastic:masterfrom
thomasneirynck:maps/text_field_disable

Conversation

@thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented Mar 17, 2021

Nullifying the text-field layout-property invalidates the local mapbox-gl tilecache. Check the value first before setting this property.

@thomasneirynck thomasneirynck added WIP Work in progress release_note:fix Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Mar 17, 2021
@thomasneirynck thomasneirynck removed the WIP Work in progress label Mar 29, 2021
@thomasneirynck thomasneirynck marked this pull request as ready for review March 29, 2021 21:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@thomasneirynck
Copy link
Contributor Author

@elasticmachine merge upstream

@thomasneirynck
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
code review, tested in chrome

@thomasneirynck
Copy link
Contributor Author

@elasticmachine merge upstream

@thomasneirynck
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.6MB 2.6MB +120.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomasneirynck thomasneirynck added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 5, 2021
@thomasneirynck thomasneirynck merged commit 1fad317 into elastic:master Apr 5, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 5, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.x / #96232

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 5, 2021
Co-authored-by: Thomas Neirynck <thomas@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 6, 2021
…-nav

* 'master' of github.com:elastic/kibana: (106 commits)
  [Lens] don't use eui variables for zindex (elastic#96117)
  Remove /src/legacy (elastic#95510)
  skip flaky suite (elastic#95899)
  [Dashboard] Fix Lens and TSVB chart tooltip positioning relative to global headers (elastic#94247)
  fixes a skipped management x-pack test (elastic#96178)
  [App Search] API logs: Add log detail flyout (elastic#96162)
  [tech-debt] Remove defunct opacity parameters from EUI shadow functions (elastic#96191)
  Add Input Controls project configuration (elastic#96238)
  [file upload] document file upload privileges and provide actionable UI when failures occur (elastic#95883)
  Revert "TS Incremental build exclude test files (elastic#95610)" (elastic#96223)
  [App Search] Added Sample Response section to Result Settings (elastic#95971)
  [Maps] Safe-erase text-field (elastic#94873)
  [RAC][Alert Triage][TGrid] Update the Alerts Table (TGrid) API to implement `renderCellValue` (elastic#96098)
  [Maps] Enable all zoom levels for all users (elastic#96093)
  Use plugin version in its publicPath (elastic#95945)
  [Enterprise Search] Expose core.chrome.setIsVisible for use in Workplace Search (elastic#95984)
  [Workplace Search] Add sub nav and fix rendering bugs in Personal dashboard (elastic#96100)
  [OBS]home page is showing incorrect value of APM throughput (tpm) (elastic#95991)
  [Observability] Exploratory View initial skeleton (elastic#94426)
  [KQL] Fixed styles of KQL textarea for the K8 theme (elastic#96190)
  ...

# Conflicts:
#	x-pack/plugins/snapshot_restore/__jest__/client_integration/helpers/restore_snapshot.helpers.ts
@thomasneirynck thomasneirynck added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.13.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants