Skip to content

Revert "Remove /src/legacy (#95510)"#96314

Closed
mistic wants to merge 1 commit intoelastic:masterfrom
mistic:revert-95510
Closed

Revert "Remove /src/legacy (#95510)"#96314
mistic wants to merge 1 commit intoelastic:masterfrom
mistic:revert-95510

Conversation

@mistic
Copy link
Contributor

@mistic mistic commented Apr 6, 2021

It reverts #95510 as it was making the kibana dev server to stuck when in use without --no-base-path.

\cc @pgayvallet

@mistic mistic added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// Team:Operations Kibana-Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Apr 6, 2021
@mistic mistic requested review from a team as code owners April 6, 2021 14:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Copy link
Contributor

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM.

@pgayvallet
Copy link
Contributor

Closing in favor of #96332

@pgayvallet pgayvallet closed this Apr 6, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// Team:Operations Kibana-Operations Team v7.13.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants