Skip to content

[Discover] Remove redundant "Filter was added" toast#155645

Merged
jughosta merged 2 commits intoelastic:mainfrom
jughosta:154993-fix-filter-toast
Apr 26, 2023
Merged

[Discover] Remove redundant "Filter was added" toast#155645
jughosta merged 2 commits intoelastic:mainfrom
jughosta:154993-fix-filter-toast

Conversation

@jughosta
Copy link
Copy Markdown
Contributor

@jughosta jughosta commented Apr 24, 2023 •
edited by kibanamachine
Loading

Closes #154993

Summary

This PR removes "Filter was added" toast (it was visible after adding filters from the Doc Viewer flyout) which was not very useful. It's also not shown when user adds filters from the grid or sidebar.

@jughosta jughosta added Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// backport:prev-minor labels Apr 24, 2023
@jughosta jughosta self-assigned this Apr 24, 2023
@jughosta jughosta changed the title [Discover] Remove "Filter was added" toast [Discover] Remove redundant "Filter was added" toast Apr 24, 2023
@jughosta jughosta marked this pull request as ready for review April 25, 2023 08:04
@jughosta jughosta requested a review from a team as a code owner April 25, 2023 08:04
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 25, 2023

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Apr 25, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 432.4KB 432.3KB -154.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 396 399 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 476 479 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

davismcphee
davismcphee approved these changes Apr 25, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled and tested locally, working well! The toast wasn't really doing anything for us anyway, so better to be consistent with the other filter buttons.

@jughosta jughosta merged commit 7534cc7 into elastic:main Apr 26, 2023
@kibanamachine kibanamachine mentioned this pull request Apr 26, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 26, 2023
@jughosta
[Discover] Remove redundant "Filter was added" toast (elastic#155645)
5811025 
Closes elastic#154993

## Summary

This PR removes "Filter was added" toast (it was visible after adding
filters from the Doc Viewer flyout) which was not very useful. It's also
not shown when user adds filters from the grid or sidebar.

(cherry picked from commit 7534cc7)
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 26, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@jughosta jughosta deleted the 154993-fix-filter-toast branch April 26, 2023 06:44
kibanamachine added a commit that referenced this pull request Apr 26, 2023
@kibanamachine @jughosta
[8.7] [Discover] Remove redundant "Filter was added" toast (#155645) (#…
ce77b30 
…155825)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Discover] Remove redundant "Filter was added" toast
(#155645)](#155645)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2023-04-26T06:30:55Z","message":"[Discover]
Remove redundant \"Filter was added\" toast (#155645)\n\nCloses
https://github.com/elastic/kibana/issues/154993\r\n\r\n##
Summary\r\n\r\nThis PR removes \"Filter was added\" toast (it was
visible after adding\r\nfilters from the Doc Viewer flyout) which was
not very useful. It's also\r\nnot shown when user adds filters from the
grid or
sidebar.","sha":"7534cc78511febd457b3ea1efca8b8c0057850de","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:skip","Team:DataDiscovery","backport:prev-minor","v8.8.0"],"number":155645,"url":"https://github.com/elastic/kibana/pull/155645","mergeCommit":{"message":"[Discover]
Remove redundant \"Filter was added\" toast (#155645)\n\nCloses
https://github.com/elastic/kibana/issues/154993\r\n\r\n##
Summary\r\n\r\nThis PR removes \"Filter was added\" toast (it was
visible after adding\r\nfilters from the Doc Viewer flyout) which was
not very useful. It's also\r\nnot shown when user adds filters from the
grid or
sidebar.","sha":"7534cc78511febd457b3ea1efca8b8c0057850de"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155645","number":155645,"mergeCommit":{"message":"[Discover]
Remove redundant \"Filter was added\" toast (#155645)\n\nCloses
https://github.com/elastic/kibana/issues/154993\r\n\r\n##
Summary\r\n\r\nThis PR removes \"Filter was added\" toast (it was
visible after adding\r\nfilters from the Doc Viewer flyout) which was
not very useful. It's also\r\nnot shown when user adds filters from the
grid or sidebar.","sha":"7534cc78511febd457b3ea1efca8b8c0057850de"}}]}]
BACKPORT-->

Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 26, 2023
@jloleysens
Merge branch 'main' into compatible-schema-change-check
ab5ff42 
* main: (1294 commits)
  [SecuritySolution] Refactor security packages (elastic#155365)
  [Discover] Show "Temporary" badge for ad-hoc data views in Alerts flyout (elastic#155717)
  [RAM] Conditional actions feedback on pr review (elastic#155804)
  [Files] Adds bulk delete method (elastic#155628)
  [Lens] Use proper way to generate absolute short URL (elastic#155512)
  [Guided onboarding] Use Kibana features to grant access (elastic#155065)
  [Index Management] Fix duped mock (elastic#155844)
  [Lens] Enhance visualization modifier popup with layer palette (elastic#155280)
  Fix flaky combobox tests on role management screen (elastic#155711)
  [Infrastructure UI] Create InventoryViewsService and InventoryViewsClient (elastic#155126)
  [Fleet] always create agent upload write indices (elastic#155729)
  [Fleet] [Cloud Security Posture] Add CloudFormation agent install method (elastic#155045)
  Add tech preview label for search applications (elastic#155649)
  [ML] AIOps: Stabilize flaky functional tests. (elastic#155710)
  [ES UI Shared] Migrate JsonEditor to monaco (elastic#155610)
  [Security Solution] Fixes security_solution storybooks always rendering in a flyout (elastic#155814)
  [Synthetics] Make error popover disappear `onMouseLeave` of metric item card (elastic#155800)
  Remove Exploratory View components from Observability (elastic#155629)
  [Discover] Remove redundant "Filter was added" toast (elastic#155645)
  [RAM][Security Solution][Alerts] Support the ability to trigger a rule action per alert generated (elastic#153611) (elastic#155384)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davismcphee davismcphee davismcphee approved these changes

Assignees

@jughosta jughosta

Labels

Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v8.7.1 v8.8.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Dashboard] Selecting any Filter option in Saved Search Flyout displays success toast even when filter was not added

5 participants

@jughosta @elasticmachine @kibana-ci @kibanamachine @davismcphee