Skip to content

Fix flaky combobox tests on role management screen#155711

Merged
thomheymann merged 1 commit intoelastic:mainfrom
thomheymann:fix-broken-role-management-tests
Apr 26, 2023
Merged

Fix flaky combobox tests on role management screen#155711
thomheymann merged 1 commit intoelastic:mainfrom
thomheymann:fix-broken-role-management-tests

Conversation

@thomheymann
Copy link
Copy Markdown
Contributor

@thomheymann thomheymann commented Apr 25, 2023 •
edited
Loading

Resolves #155447
Resolves #155448
Resolves #137393
Resolves #155446

Flaky test runner: ✅ 50/50 (https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2169)

@thomheymann thomheymann added Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// release_note:skip Skip the PR/issue when compiling release notes v8.8.0 labels Apr 25, 2023
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Apr 25, 2023

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 396 399 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 476 479 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomheymann thomheymann marked this pull request as ready for review April 25, 2023 13:55
@thomheymann thomheymann requested a review from a team as a code owner April 25, 2023 13:55
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 25, 2023

Pinging @elastic/kibana-security (Team:Security)

jeramysoucy
jeramysoucy approved these changes Apr 25, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@jeramysoucy jeramysoucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! LGTM

@thomheymann thomheymann merged commit 24712d4 into elastic:main Apr 26, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Apr 26, 2023
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 26, 2023
@jloleysens
Merge branch 'main' into compatible-schema-change-check
ab5ff42 
* main: (1294 commits)
  [SecuritySolution] Refactor security packages (elastic#155365)
  [Discover] Show "Temporary" badge for ad-hoc data views in Alerts flyout (elastic#155717)
  [RAM] Conditional actions feedback on pr review (elastic#155804)
  [Files] Adds bulk delete method (elastic#155628)
  [Lens] Use proper way to generate absolute short URL (elastic#155512)
  [Guided onboarding] Use Kibana features to grant access (elastic#155065)
  [Index Management] Fix duped mock (elastic#155844)
  [Lens] Enhance visualization modifier popup with layer palette (elastic#155280)
  Fix flaky combobox tests on role management screen (elastic#155711)
  [Infrastructure UI] Create InventoryViewsService and InventoryViewsClient (elastic#155126)
  [Fleet] always create agent upload write indices (elastic#155729)
  [Fleet] [Cloud Security Posture] Add CloudFormation agent install method (elastic#155045)
  Add tech preview label for search applications (elastic#155649)
  [ML] AIOps: Stabilize flaky functional tests. (elastic#155710)
  [ES UI Shared] Migrate JsonEditor to monaco (elastic#155610)
  [Security Solution] Fixes security_solution storybooks always rendering in a flyout (elastic#155814)
  [Synthetics] Make error popover disappear `onMouseLeave` of metric item card (elastic#155800)
  Remove Exploratory View components from Observability (elastic#155629)
  [Discover] Remove redundant "Filter was added" toast (elastic#155645)
  [RAM][Security Solution][Alerts] Support the ability to trigger a rule action per alert generated (elastic#153611) (elastic#155384)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment