Skip to content

[ES UI Shared] Migrate JsonEditor to monaco#155610

Merged
sabarasaba merged 5 commits intoelastic:mainfrom
sabarasaba:json_editor-migrate-to-monaco
Apr 26, 2023
Merged

[ES UI Shared] Migrate JsonEditor to monaco#155610
sabarasaba merged 5 commits intoelastic:mainfrom
sabarasaba:json_editor-migrate-to-monaco

Conversation

@sabarasaba
Copy link
Copy Markdown
Member

@sabarasaba sabarasaba commented Apr 24, 2023 •
edited
Loading

Partially addresses: #107215

Summary

This PR updates the JsonEditor component to use CodeEditor/Monaco instead. Note that CodeEditor is a kibana wide abstraction built on top of Monaco and located at @kbn/kibana-react-plugin/public.

@sabarasaba sabarasaba self-assigned this Apr 24, 2023
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Apr 25, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 526.0KB 526.0KB -18.0B
ingestPipelines 453.4KB 453.4KB -9.0B
total -27.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
esUiShared 152.4KB 152.4KB -76.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 16 18 +2
securitySolution 395 398 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 17 19 +2
securitySolution 475 478 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba

@sabarasaba sabarasaba marked this pull request as ready for review April 25, 2023 10:05
@sabarasaba sabarasaba requested a review from a team as a code owner April 25, 2023 10:05
@sabarasaba sabarasaba added release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// backport:skip This PR does not require backporting v8.8.0 labels Apr 25, 2023
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 25, 2023

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

yuliacech
yuliacech approved these changes Apr 25, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for migrating the json editor, @sabarasaba!
Tested locally and it looks as expected. I noticed that we use a mock for code editor from kibana-react in a lot of places. Do you mind opening an issue to put the mock into the kibana-react plugin and then import it from there to other plugins?

@sabarasaba sabarasaba added v8.9.0 and removed v8.8.0 labels Apr 26, 2023
@sabarasaba
Copy link
Copy Markdown
Member Author

sabarasaba commented Apr 26, 2023

Thanks for the review @yuliacech! Thanks for the suggestion, I agree its a bit tedious having to mock the same thing over and over. I've created #155831 to track that.

@sabarasaba sabarasaba merged commit 9bbd508 into elastic:main Apr 26, 2023
@sabarasaba sabarasaba mentioned this pull request Apr 26, 2023
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 26, 2023
@jloleysens
Merge branch 'main' into compatible-schema-change-check
ab5ff42 
* main: (1294 commits)
  [SecuritySolution] Refactor security packages (elastic#155365)
  [Discover] Show "Temporary" badge for ad-hoc data views in Alerts flyout (elastic#155717)
  [RAM] Conditional actions feedback on pr review (elastic#155804)
  [Files] Adds bulk delete method (elastic#155628)
  [Lens] Use proper way to generate absolute short URL (elastic#155512)
  [Guided onboarding] Use Kibana features to grant access (elastic#155065)
  [Index Management] Fix duped mock (elastic#155844)
  [Lens] Enhance visualization modifier popup with layer palette (elastic#155280)
  Fix flaky combobox tests on role management screen (elastic#155711)
  [Infrastructure UI] Create InventoryViewsService and InventoryViewsClient (elastic#155126)
  [Fleet] always create agent upload write indices (elastic#155729)
  [Fleet] [Cloud Security Posture] Add CloudFormation agent install method (elastic#155045)
  Add tech preview label for search applications (elastic#155649)
  [ML] AIOps: Stabilize flaky functional tests. (elastic#155710)
  [ES UI Shared] Migrate JsonEditor to monaco (elastic#155610)
  [Security Solution] Fixes security_solution storybooks always rendering in a flyout (elastic#155814)
  [Synthetics] Make error popover disappear `onMouseLeave` of metric item card (elastic#155800)
  Remove Exploratory View components from Observability (elastic#155629)
  [Discover] Remove redundant "Filter was added" toast (elastic#155645)
  [RAM][Security Solution][Alerts] Support the ability to trigger a rule action per alert generated (elastic#153611) (elastic#155384)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yuliacech yuliacech yuliacech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sabarasaba sabarasaba

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v8.8.0 v8.9.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sabarasaba @kibana-ci @elasticmachine @yuliacech @kibanamachine