Skip to content

[8.7] [Discover] Remove redundant "Filter was added" toast (#155645)#155825

Merged
kibanamachine merged 1 commit intoelastic:8.7from
kibanamachine:backport/8.7/pr-155645
Apr 26, 2023
Merged

[8.7] [Discover] Remove redundant "Filter was added" toast (#155645)#155825
kibanamachine merged 1 commit intoelastic:8.7from
kibanamachine:backport/8.7/pr-155645

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

@kibanamachine kibanamachine commented Apr 26, 2023

Backport

This will backport the following commits from main to 8.7:

Questions ?

Please refer to the Backport tool documentation

@jughosta
[Discover] Remove redundant "Filter was added" toast (elastic#155645)
5811025 
Closes elastic#154993

## Summary

This PR removes "Filter was added" toast (it was visible after adding
filters from the Doc Viewer flyout) which was not very useful. It's also
not shown when user adds filters from the grid or sidebar.

(cherry picked from commit 7534cc7)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Apr 26, 2023
@kibanamachine kibanamachine enabled auto-merge (squash) April 26, 2023 06:36
@kibanamachine kibanamachine mentioned this pull request Apr 26, 2023
Merged
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Apr 26, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #56 / management runtime fields create composite runtime field should create runtime field
  • [job] [logs] FTR Configs #56 / management runtime fields create composite runtime field should delete runtime field
  • [job] [logs] FTR Configs #56 / management runtime fields create composite runtime field should modify runtime field

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 392.3KB 392.1KB -154.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

@kibanamachine kibanamachine merged commit ce77b30 into elastic:8.7 Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jughosta jughosta

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kibanamachine @kibana-ci @jughosta