Skip to content

[RAM] Conditional actions feedback on pr review#155804

Merged
XavierM merged 3 commits intoelastic:mainfrom
XavierM:fix-ui-conditional-actions
Apr 26, 2023
Merged

[RAM] Conditional actions feedback on pr review#155804
XavierM merged 3 commits intoelastic:mainfrom
XavierM:fix-ui-conditional-actions

Conversation

@XavierM
Copy link
Copy Markdown
Contributor

@XavierM XavierM commented Apr 25, 2023

Summary

image

Checklist

@XavierM XavierM added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.8.0 labels Apr 25, 2023
@XavierM XavierM requested a review from a team as a code owner April 25, 2023 21:40
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 25, 2023

Pinging @elastic/response-ops (Team:ResponseOps)

@XavierM XavierM mentioned this pull request Apr 25, 2023
Merged
1 task
@XavierM XavierM enabled auto-merge (squash) April 25, 2023 21:42
JiaweiWu
JiaweiWu approved these changes Apr 25, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@JiaweiWu JiaweiWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and everything working as expected, LGTM!

@XavierM XavierM disabled auto-merge April 26, 2023 00:36
@XavierM
Copy link
Copy Markdown
Contributor Author

XavierM commented Apr 26, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Apr 26, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #3 / timeline flyout button the (+) button popover menu owns focus

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.4MB 1.4MB -9.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM merged commit 57f3b38 into elastic:main Apr 26, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Apr 26, 2023
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 26, 2023
@jloleysens
Merge branch 'main' into compatible-schema-change-check
ab5ff42 
* main: (1294 commits)
  [SecuritySolution] Refactor security packages (elastic#155365)
  [Discover] Show "Temporary" badge for ad-hoc data views in Alerts flyout (elastic#155717)
  [RAM] Conditional actions feedback on pr review (elastic#155804)
  [Files] Adds bulk delete method (elastic#155628)
  [Lens] Use proper way to generate absolute short URL (elastic#155512)
  [Guided onboarding] Use Kibana features to grant access (elastic#155065)
  [Index Management] Fix duped mock (elastic#155844)
  [Lens] Enhance visualization modifier popup with layer palette (elastic#155280)
  Fix flaky combobox tests on role management screen (elastic#155711)
  [Infrastructure UI] Create InventoryViewsService and InventoryViewsClient (elastic#155126)
  [Fleet] always create agent upload write indices (elastic#155729)
  [Fleet] [Cloud Security Posture] Add CloudFormation agent install method (elastic#155045)
  Add tech preview label for search applications (elastic#155649)
  [ML] AIOps: Stabilize flaky functional tests. (elastic#155710)
  [ES UI Shared] Migrate JsonEditor to monaco (elastic#155610)
  [Security Solution] Fixes security_solution storybooks always rendering in a flyout (elastic#155814)
  [Synthetics] Make error popover disappear `onMouseLeave` of metric item card (elastic#155800)
  Remove Exploratory View components from Observability (elastic#155629)
  [Discover] Remove redundant "Filter was added" toast (elastic#155645)
  [RAM][Security Solution][Alerts] Support the ability to trigger a rule action per alert generated (elastic#153611) (elastic#155384)
  ...
Zacqary
Zacqary reviewed May 4, 2023
View reviewed changes
...triggers_actions_ui/public/application/sections/action_connector_form/action_notify_when.tsx
'xpack.triggersActionsUI.sections.ruleForm.frequencyNotifyWhen.label',
{
defaultMessage: 'Every',
defaultMessage: 'Run action every',
Copy link
Copy Markdown
Contributor

@Zacqary Zacqary May 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-05-04 at 3 43 05 PM

We need to revert this until we get rid of the flyout

@Zacqary Zacqary mentioned this pull request May 4, 2023
Merged
Zacqary added a commit that referenced this pull request May 22, 2023
@Zacqary
[RAM] Change truncated 'run action every' to visible 'run every' (#15…
8a9fb98 
…6753)

## Summary

#155804 introduced this bug:

<img width="568" alt="Screenshot 2023-05-04 at 3 43 05 PM"
src="https://user-images.githubusercontent.com/1445834/236325207-6ba7ba7d-c056-4444-9cf4-f3e6287c271b.png">


After:

<img width="562" alt="Screenshot 2023-05-04 at 3 45 09 PM"
src="https://user-images.githubusercontent.com/1445834/236325256-34926a1a-8630-469f-8bdc-01f375648779.png">
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 22, 2023
@Zacqary
[RAM] Change truncated 'run action every' to visible 'run every' (ela…
376c7c0 
…stic#156753)

## Summary

elastic#155804 introduced this bug:

<img width="568" alt="Screenshot 2023-05-04 at 3 43 05 PM"
src="https://user-images.githubusercontent.com/1445834/236325207-6ba7ba7d-c056-4444-9cf4-f3e6287c271b.png">

After:

<img width="562" alt="Screenshot 2023-05-04 at 3 45 09 PM"
src="https://user-images.githubusercontent.com/1445834/236325256-34926a1a-8630-469f-8bdc-01f375648779.png">

(cherry picked from commit 8a9fb98)
delanni pushed a commit to delanni/kibana that referenced this pull request May 25, 2023
@Zacqary @delanni
[RAM] Change truncated 'run action every' to visible 'run every' (ela…
3355148 
…stic#156753)

## Summary

elastic#155804 introduced this bug:

<img width="568" alt="Screenshot 2023-05-04 at 3 43 05 PM"
src="https://user-images.githubusercontent.com/1445834/236325207-6ba7ba7d-c056-4444-9cf4-f3e6287c271b.png">


After:

<img width="562" alt="Screenshot 2023-05-04 at 3 45 09 PM"
src="https://user-images.githubusercontent.com/1445834/236325256-34926a1a-8630-469f-8bdc-01f375648779.png">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zacqary Zacqary Zacqary left review comments

@JiaweiWu JiaweiWu JiaweiWu approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.8.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@XavierM @elasticmachine @kibana-ci @Zacqary @JiaweiWu @kibanamachine