[SecuritySolution] Refactor security packages by semd · Pull Request #155365 · elastic/kibana

semd · 2023-04-20T10:46:31Z

Summary

Moves packages/security-solution/ to x-pack/packages/security-solution/
Moves x-pack/packages/kbn-securitysolution-* into the new x-pack/packages/security-solution/

It contains 3 packages now:

data_view/
ecs_data_quality_dashboard/
side_nav/

Package names and ids have not changed.

Other

eslint configured for all the packages in the directory
i18n prefix securitySolutionPackages configured for all packages in the directory
generic storybook configuration, run with: yarn storybook security_solution_packages

elasticmachine · 2023-04-20T10:46:35Z

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

…urity_packages

…m/semd/kibana into 155301_refactor_security_packages

semd · 2023-04-20T15:16:38Z

@elasticmachine merge upstream

semd · 2023-04-21T10:10:10Z

@elasticmachine merge upstream

semd · 2023-04-21T12:49:54Z

@elasticmachine merge upstream

machadoum

Explore team code LGTM!

semd · 2023-04-21T13:07:21Z

@elasticmachine merge upstream

semd · 2023-04-21T14:58:46Z

@elasticmachine merge upstream

semd · 2023-04-21T15:27:17Z

@elasticmachine merge upstream

semd · 2023-04-24T09:01:12Z

@elasticmachine merge upstream

semd · 2023-04-24T10:10:57Z

waiting for #155581 changes to be included in this PR

…m/semd/kibana into 155301_refactor_security_packages

…-fix'

x-pack/packages/security-solution/ecs_data_quality_dashboard/jest.config.js

andrew-goldstein

Thanks for moving the security packages to a common home @semd! 🙏
✅ Data Quality dashboard desk tested locally
LGTM 🚀

…urity_packages

semd · 2023-04-26T11:05:16Z

@elasticmachine merge upstream

kibana-ci · 2023-04-26T12:05:37Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	9.1MB	9.1MB	+4.0KB

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`@kbn/security-solution-side-nav`	1	2	+1
`@kbn/securitysolution-data-table`	3	4	+1
`enterpriseSearch`	17	19	+2
`securitySolution`	399	402	+3
total			+7

Total ESLint disabled count

id	before	after	diff
`@kbn/security-solution-side-nav`	2	3	+1
`@kbn/securitysolution-data-table`	5	6	+1
`enterpriseSearch`	18	20	+2
`securitySolution`	479	482	+3
total			+7

History

💔 Build #123395 failed addb3be
💚 Build #122871 succeeded c8f093b
💚 Build #122309 succeeded 0b87015
💔 Build #122070 failed 90b64c9
💔 Build #122045 failed 5077331

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @semd

* main: (1294 commits) [SecuritySolution] Refactor security packages (elastic#155365) [Discover] Show "Temporary" badge for ad-hoc data views in Alerts flyout (elastic#155717) [RAM] Conditional actions feedback on pr review (elastic#155804) [Files] Adds bulk delete method (elastic#155628) [Lens] Use proper way to generate absolute short URL (elastic#155512) [Guided onboarding] Use Kibana features to grant access (elastic#155065) [Index Management] Fix duped mock (elastic#155844) [Lens] Enhance visualization modifier popup with layer palette (elastic#155280) Fix flaky combobox tests on role management screen (elastic#155711) [Infrastructure UI] Create InventoryViewsService and InventoryViewsClient (elastic#155126) [Fleet] always create agent upload write indices (elastic#155729) [Fleet] [Cloud Security Posture] Add CloudFormation agent install method (elastic#155045) Add tech preview label for search applications (elastic#155649) [ML] AIOps: Stabilize flaky functional tests. (elastic#155710) [ES UI Shared] Migrate JsonEditor to monaco (elastic#155610) [Security Solution] Fixes security_solution storybooks always rendering in a flyout (elastic#155814) [Synthetics] Make error popover disappear `onMouseLeave` of metric item card (elastic#155800) Remove Exploratory View components from Observability (elastic#155629) [Discover] Remove redundant "Filter was added" toast (elastic#155645) [RAM][Security Solution][Alerts] Support the ability to trigger a rule action per alert generated (elastic#153611) (elastic#155384) ...

semd added 6 commits April 20, 2023 11:20

move security-solution package directory

96d302a

ecs data qa dashboard moved

7f6fb80

translations prefixes changed

13d39ee

move data_table package

2da6b7e

data_table configs and translations

9b00173

storybook fixes

98b7395

semd added refactoring technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v8.8.0 labels Apr 20, 2023

semd self-assigned this Apr 20, 2023

semd requested review from a team as code owners April 20, 2023 10:46

kibanamachine added 2 commits April 20, 2023 10:52

[CI] Auto-commit changed files from 'node scripts/lint_packages --fix'

acf1c1e

[CI] Auto-commit changed files from 'node scripts/generate codeowners'

07c69e3

lgestc approved these changes Apr 20, 2023

View reviewed changes

semd added 4 commits April 20, 2023 14:19

translations auto fixed

295b159

Merge remote-tracking branch 'upstream/main' into 155301_refactor_sec…

0cf6687

…urity_packages

fix lint errors

3a97c00

Merge branch '155301_refactor_security_packages' of https://github.co…

23cb83e

…m/semd/kibana into 155301_refactor_security_packages

jbudz approved these changes Apr 20, 2023

View reviewed changes

Merge branch 'main' into 155301_refactor_security_packages

c147bc8

Merge branch 'main' into 155301_refactor_security_packages

3985d0b

Merge branch 'main' into 155301_refactor_security_packages

9e9f8b1

machadoum approved these changes Apr 21, 2023

View reviewed changes

Merge branch 'main' into 155301_refactor_security_packages

8e5b8d8

Merge branch 'main' into 155301_refactor_security_packages

5077331

Merge branch 'main' into 155301_refactor_security_packages

90b64c9

Merge branch 'main' into 155301_refactor_security_packages

0b87015

semd added 7 commits April 25, 2023 10:08

help git to make merge easier

b2024c5

conflicts solved

25e5a97

moving again

f5619e0

translations prefixes

4e3c6ad

translations prefixes

281e4f2

i18n

80538ed

Merge branch '155301_refactor_security_packages' of https://github.co…

d06ff1a

…m/semd/kibana into 155301_refactor_security_packages

semd requested a review from andrew-goldstein April 25, 2023 09:45

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

c8f093b

…-fix'

andrew-goldstein reviewed Apr 25, 2023

View reviewed changes

x-pack/packages/security-solution/ecs_data_quality_dashboard/jest.config.js Outdated Show resolved Hide resolved

andrew-goldstein approved these changes Apr 25, 2023

View reviewed changes

semd added 2 commits April 26, 2023 11:36

Merge remote-tracking branch 'upstream/main' into 155301_refactor_sec…

7a59e69

…urity_packages

coverage dir

addb3be

semd enabled auto-merge (squash) April 26, 2023 09:41

Merge branch 'main' into 155301_refactor_security_packages

f143f6c

semd merged commit 202f13f into elastic:main Apr 26, 2023

kibanamachine added the backport:skip This PR does not require backporting label Apr 26, 2023

Conversation

semd commented Apr 20, 2023

Summary

Other

Uh oh!

elasticmachine commented Apr 20, 2023

Uh oh!

semd commented Apr 20, 2023

Uh oh!

semd commented Apr 21, 2023

Uh oh!

semd commented Apr 21, 2023

Uh oh!

machadoum left a comment

Choose a reason for hiding this comment

Uh oh!

semd commented Apr 21, 2023

Uh oh!

semd commented Apr 21, 2023

Uh oh!

semd commented Apr 21, 2023

Uh oh!

semd commented Apr 24, 2023

Uh oh!

semd commented Apr 24, 2023

Uh oh!

Uh oh!

andrew-goldstein left a comment

Choose a reason for hiding this comment

Uh oh!

semd commented Apr 26, 2023

Uh oh!

kibana-ci commented Apr 26, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants