Skip to content

[Discover] Remove redundant "Filter was added" toast #155645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jughosta merged 2 commits into from
Apr 26, 2023
Merged

[Discover] Remove redundant "Filter was added" toast #155645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bae8d1
[Discover] Remove "Filter was added" toast
jughosta Apr 24, 2023
03331c8
Merge branch 'main' into 154993-fix-filter-toast
jughosta Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions src/plugins/discover/public/components/discover_grid/discover_grid_flyout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,18 +217,7 @@ export function DiscoverGridFlyout({
hit={actualHit}
columns={columns}
dataView={dataView}
filter={
onFilter
? (mapping, value, mode) => {
onFilter(mapping, value, mode);
services.toastNotifications.addSuccess(
i18n.translate('discover.grid.flyout.toastFilterAdded', {
defaultMessage: `Filter was added`,
})
);
}
: undefined
}
filter={onFilter}
onRemoveColumn={(columnName: string) => {
onRemoveColumn(columnName);
services.toastNotifications.addSuccess(
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/fr-FR.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2362,7 +2362,6 @@
"discover.grid.flyout.documentNavigation": "Navigation dans le document",
"discover.grid.flyout.toastColumnAdded": "La colonne \"{columnName}\" a été ajoutée.",
"discover.grid.flyout.toastColumnRemoved": "La colonne \"{columnName}\" a été supprimée.",
"discover.grid.flyout.toastFilterAdded": "Le filtre a été ajouté.",
"discover.grid.selectDoc": "Sélectionner le document \"{rowNumber}\"",
"discover.grid.tableRow.detailHeading": "Document développé",
"discover.grid.tableRow.viewSingleDocumentLinkTextSimple": "Document unique",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2362,7 +2362,6 @@
"discover.grid.flyout.documentNavigation": "ドキュメントナビゲーション",
"discover.grid.flyout.toastColumnAdded": "列'{columnName}'が追加されました",
"discover.grid.flyout.toastColumnRemoved": "列'{columnName}'が削除されました",
"discover.grid.flyout.toastFilterAdded": "フィルターが追加されました",
"discover.grid.selectDoc": "ドキュメント'{rowNumber}'を選択",
"discover.grid.tableRow.detailHeading": "拡張ドキュメント",
"discover.grid.tableRow.viewSingleDocumentLinkTextSimple": "1つのドキュメント",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2362,7 +2362,6 @@
"discover.grid.flyout.documentNavigation": "文档导航",
"discover.grid.flyout.toastColumnAdded": "已添加列“{columnName}”",
"discover.grid.flyout.toastColumnRemoved": "已移除列“{columnName}”",
"discover.grid.flyout.toastFilterAdded": "已添加筛选",
"discover.grid.selectDoc": "选择文档“{rowNumber}”",
"discover.grid.tableRow.detailHeading": "已展开文档",
"discover.grid.tableRow.viewSingleDocumentLinkTextSimple": "单个文档",
Expand Down