Upgrade EUI to v48.1.1 #125023
Merged
Upgrade EUI to v48.1.1 #125023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breehall
added
release_note:skip
…by renderCellValue and cellActions
…ssed when popover is open)
- pass more missing `colIndex`s - pass RowAction colIndex, because it's inheriting types from EUI - omit colIndex from the leading controls column renderer, because it doesn't need them
- pass colIndex (which fixes EUI type match issue) - DRY out ariaColIndex logic - rename ariaRowindex passed to StatefulCell to rowIndex
…the tokensToSkip array
…into eui-upgrade-47.0.0 Merging in latest commits from eui-upgrade-47.0.0
- `visibleRowIndex` is not a prop passed back by `popoverContents` (see `EuiDataGridCellValueElementProps`), but `rowIndex` is
…into eui-upgrade-47.0.0 Merging in the latest code from eui-upgrade-47.0.0
Contributor
|
Removing the v7.17.1 label, we haven't backported any recent upgrades to 7.x recently |
Contributor
|
Oh, 8.1 FF was a week or two ago, so we should probably change that as well. We don't need this to be on 8.1, correct @chandlerprall @thompsongl? |
Contributor
|
8.2 is the right target 👍 |
- in actuality this is an EUI typing issue, children is a ReactElement, not a ReactNode. However we'll shortly be deprecationg popoverContents, so this isn't worth fixing right now
…into eui-upgrade-47.0.0 Pulling in the latest code from eui-upgrade-47.0.0
… license_checker config files
…changes from EUI version 48.0.0
…ia-checked attribute instead of the aria-selected attribute as part of an accessibility update to aria made in EUI PR 5581
…uality of strings. These unit tests were for the EuiSelectable and EuiFilterGroup components. Both of these components contain and utilize EuiScreenReaderOnly which provides text that is used for screen readers, but can still be viewed and queried in the DOM. These tests have been updated with the EuiScreenReaderOnly text in mind.
jloleysens
approved these changes
Feb 17, 2022
Contributor
jloleysens
left a comment
jloleysens
left a comment
There was a problem hiding this comment.
AppServices LGTM, snap files changed. Did not test new version locally.
mbondyra
approved these changes
Feb 17, 2022
Contributor
mbondyra
left a comment
mbondyra
left a comment
There was a problem hiding this comment.
VisEditors changes LGTM 👌🏼
Member
|
@elasticmachine merge upstream |
shahzad31
approved these changes
Feb 17, 2022
Contributor
|
@elasticmachine merge upstream |
Contributor
|
@elasticmachine merge upstream |
alisonelizabeth
approved these changes
Feb 22, 2022
Contributor
alisonelizabeth
left a comment
alisonelizabeth
left a comment
There was a problem hiding this comment.
platform deployment management changes LGTM
… bootsrap to resolve a merge conflict in the yarn.lock file
Contributor
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Contributor
Author
|
Merging this PR with the current reviews as it has been open for review for about a week and is passing all CI tests. |
jportner
pushed a commit
to jportner/kibana
that referenced
this pull request
Feb 23, 2022
[email protected] was accidentally added with elastic#125023. This commit removes the redundant dependency in favor of [email protected].
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
added
the
backport missing
cee-chen
added
backport:skip
lucasfcosta
pushed a commit
to lucasfcosta/kibana
that referenced
this pull request
Mar 2, 2022
* Upgraded the version of EUI to 47.0.0 and react-beautiful-dnd (an EUI dependancy) to 13.1.0 * Update i18n mappings with required changes * Fix all data grid types/tests missing the new `colIndex` prop passed by renderCellValue and cellActions * Fix cellActions closePopover type to indicate conditionality (only passed when popover is open) * Fix more datagrid colIndex errors - pass more missing `colIndex`s - pass RowAction colIndex, because it's inheriting types from EUI - omit colIndex from the leading controls column renderer, because it doesn't need them * Improve StatefulCell typing - pass colIndex (which fixes EUI type match issue) - DRY out ariaColIndex logic - rename ariaRowindex passed to StatefulCell to rowIndex * Updated i18n_eui_mapping tests to add euiSelectable.searchResults to the tokensToSkip array * Fix failing ML datagrid FTR test - `visibleRowIndex` is not a prop passed back by `popoverContents` (see `EuiDataGridCellValueElementProps`), but `rowIndex` is * Revert attempted ML type change - in actuality this is an EUI typing issue, children is a ReactElement, not a ReactNode. However we'll shortly be deprecationg popoverContents, so this isn't worth fixing right now * Update test files to include up to date snapshots of code samples * Updated a test snapshots to match the latest version of code samples * Upgraded the version of EUI from 47.0.0 to 48.0.0 in package.json and license_checker config files * Update the required i18n translation mapping file with additions and changes from EUI version 48.0.0 * Updated three security screen accessibility tests to check for the aria-checked attribute instead of the aria-selected attribute as part of an accessibility update to aria made in EUI PR 5581 * Updated two unit cases to that are responsible for checking strict equality of strings. These unit tests were for the EuiSelectable and EuiFilterGroup components. Both of these components contain and utilize EuiScreenReaderOnly which provides text that is used for screen readers, but can still be viewed and queried in the DOM. These tests have been updated with the EuiScreenReaderOnly text in mind. * Code clean up and added a missing internationalization token * Ran yarn kbn bootstrap to update the yarn lock file * Fix failing ML FTR test - EuiSelectable now relies on aria-checked to indicate selected state, per W3 spec * Fix failing functional tests that click the datagrid cell expand button .euiDataGridRowCell__expandButtonIcon was deprecated in favor of a shared .euiDataGridRowCell__actionButtonIcon class, but the expand action is always the last one * Upgrade to 48.1.1 * Switch to data-test-subj for datagrid cell expansion selectors * Switch to new `data-test-selected` attribute over `aria-checked` * Update snapshots/Jest tests to account for EuiSelectable use in EuiFilter Co-authored-by: Constance Chen <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
tylersmalley
added
ci:cloud-deploy
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
[email protected] ⏩ [email protected]
48.1.1data-test-subjattribute toEuiDataGridcell expansion buttons (#5643)data-test-selectedattribute toEuiSelectablelist options (#5643)48.1.0EuiSelectablekeypress scenarios (#5613)FieldValueSelectionFilterinEuiSearchBarto useEuiSelectable(#5387)lineDashed,lineDotted, andlineSolidglyphs toEuiIcon(#5633)colorModereturn type in theme context utilities (#5639)48.0.0EuiSuggestto useEuiSelectable(#5157)EuiTableresolveWidthAsStyleutil (#5615)euiSelectableTemplateSitewideFormatOptionsutil (#5620)Bug fixes
EuiDataGridto correctly remove the cell expansion action button when a column sets bothcellActionsandisExpandableto false (#5592)EuiDataGridre-playing the cell actions animation when hovering over an already-focused cell (#5592)EuiDataGridauto row heights bugging out when cell popovers are opened (#5622)Breaking changes
EuiSuggestInput(#5157)aria-labeloraria-labelledbyforEuiSuggest(#5157)sendValueprop toonSearchChangeforEuiSuggest(#5157)47.0.0EuiDataGridfullscreen, cell focus, and cell popover state via therefprop (#5590)paddingSizeprop toEuiSelectableList(#5581)errorMessageprop toEuiSelectable(#5581)EuiSelectableaccessibility (#5581)tokenTagdesign to look more like a tag (#5553).euiToken--squareto look more like a square (#5553)Bug fixes
EuiInMemoryTable'sonTableChangecallback not returning the correctsort.fieldvalue on pagination (#5588)EuiFilePickerallowing files to be removed whendisabled(#5603)Breaking changes
46.2.0EuiDataGrids with scrolling content to always have a border around the grid body and any scrollbars (#5563)EuiDataGrid's body to a light gray background, which primarily shows when scrolling through virtualized content (#5562)idfor the generated label inEuiFormRow(#5574)EuiPopoverto aid screen reader announcements (#5574)refpassthroughs toEuiIputPopoversubcomponents (#5574)EuiScreenReaderLivecomponent for updateablearia-liveregions (#5567)Bug fixes
EuiComboBoxPillclose button had a nested interactive element (#5560)EuiDataGridwhen clicking another cell header with an already-open cell header popover (#5556)EuiDataGridto always focus back into the grid on pagination (#5587)EuiDataGridandEuiTablepagination potentially rendering out view on narrow tables with many pages (#5561)