[EuiDataGrid] Fix inconsistent cell header focus when clicking another cell header when a cell header popover is already open #5556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- when clicking to another header cell when a cell header popover is already open
cee-chen
force-pushed
the
datagrid/5352
branch
2 times, most recently
from
f116852 to
2c37ee4
Compare
Contributor
Author
|
@breehall Was hoping you had some time this week to review this small datagrid bug - let me know if not! |
cee-chen
force-pushed
the
datagrid/5352
branch
from
2c37ee4 to
5f7a109
Compare
cee-chen
changed the title
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5556/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5556/ |
breehall
approved these changes
Jan 26, 2022
Contributor
breehall
left a comment
breehall
left a comment
There was a problem hiding this comment.
This looks good and it's awesome that the solution was a quick fix. I checked this in the PR preview with mouse and keyboard navigation. Thanks Constance!
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5556/ |
gdimitropoulos
pushed a commit
to gdimitropoulos/eui
that referenced
this pull request
Apr 21, 2022
…r cell header when a cell header popover is already open (elastic#5556) * Fix cell header focus not correctly updating - when clicking to another header cell when a cell header popover is already open * Add changelog entry * Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #5352
When a cell header's actions popover is already open, clicking another header cell does not correctly update focus. Note that this bug seems to only occur on webkit browsers (Chrome/Edge/Safari), and does not occur on production on Firefox.
Before
Note how the blue focus ring keeps jumping back to the first cell header.
After
Note how the blue focus ring now correctly jumps to the most recently clicked cell header.
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for any docs examples- [ ] Checked for breaking changes and labeled appropriately