[EuiComboBox][KEYBOARD]: Removing tabindex -1 from EuiComboboxPill SVG
#5560
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5560/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5560/ |
cee-chen
suggested changes
Jan 25, 2022
thompsongl
approved these changes
Jan 27, 2022
Contributor
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
👍 Resolves the axe warning and the svg is still not focusable
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5560/ |
cee-chen
reviewed
Jan 27, 2022
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5560/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our
EuiComboBoxcomponent had a nested SVG with a tabindex -1 passed into...closeButtonPropsthat was causing axe to throw a violation. We removed the negative tabindex because the SVG is nested inside a standard button.Closes #5545
Checklist
Props have proper autodocs and playground togglesAdded documentation