Skip to content

[Lens] Line styles form adapted to the new design#125955

Merged
mbondyra merged 1 commit intoelastic:mainfrom
mbondyra:lens/line_styles_changed
Feb 24, 2022
Merged

[Lens] Line styles form adapted to the new design#125955
mbondyra merged 1 commit intoelastic:mainfrom
mbondyra:lens/line_styles_changed

Conversation

@mbondyra
Copy link
Copy Markdown
Contributor

@mbondyra mbondyra commented Feb 17, 2022 •
edited
Loading

Needs to wait for #125651 ✅ and #125023 ✅ to be merged

Before:
Screenshot 2022-02-17 at 17 56 44

After:
Screenshot 2022-02-24 at 09 09 44

@mbondyra mbondyra added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v8.2.0 labels Feb 17, 2022
@mbondyra mbondyra force-pushed the lens/line_styles_changed branch from 1fe358d to bf3d7c0 Compare February 17, 2022 17:06
@elastic elastic deleted a comment from kibana-ci Feb 17, 2022
@mbondyra mbondyra force-pushed the lens/line_styles_changed branch 2 times, most recently from bb87de7 to a1a6a4f Compare February 24, 2022 08:05
@mbondyra mbondyra force-pushed the lens/line_styles_changed branch from a1a6a4f to 07f2cc6 Compare February 24, 2022 08:07
@mbondyra mbondyra marked this pull request as ready for review February 24, 2022 08:10
@mbondyra mbondyra requested a review from a team as a code owner February 24, 2022 08:10
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 24, 2022

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

dej611
dej611 approved these changes Feb 24, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with Safari 👍

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Feb 24, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.1MB 1.1MB +46.0B

History

  • 💚 Build #25113 succeeded bb87de76bcdc7474edae79cb23b2b91571d70368
  • 💔 Build #25054 failed bf3d7c0789370b12037e76b2129c99ba854f49e6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mbondyra mbondyra merged commit 6b5fb28 into elastic:main Feb 24, 2022
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 28, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125955 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 28, 2022
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 1, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125955 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 2, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125955 or prevent reminders by adding the backport:skip label.

@stratoula stratoula added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Mar 2, 2022
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request Mar 2, 2022
@mbondyra
[Lens] change line styles waiting for eui upgrade (elastic#125955)
9c20f04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dej611 dej611 dej611 approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mbondyra @elasticmachine @kibana-ci @kibanamachine @dej611 @stratoula