Skip to content

Collapse url-parse dependencies#126301

Merged
jportner merged 1 commit intoelastic:mainfrom
jportner:fix-url-parse
Feb 24, 2022
Merged

Collapse url-parse dependencies#126301
jportner merged 1 commit intoelastic:mainfrom
jportner:fix-url-parse

Conversation

@jportner
Copy link
Contributor

@jportner jportner commented Feb 23, 2022

In #126119, we upgraded from url-parse@1.5.3 to url-parse@1.5.9.

Afterwards, url-parse@1.5.6 was accidentally added with #125023.

This PR removes the redundant dependency in favor of url-parse@1.5.9.

url-parse@1.5.6 was accidentally added with elastic#125023.
This commit removes the redundant dependency in favor of
url-parse@1.5.9.
@jportner jportner added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v8.2.0 labels Feb 23, 2022
@jportner jportner enabled auto-merge (squash) February 23, 2022 22:54
@jportner jportner requested a review from watson February 23, 2022 22:54
@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-npmDll 4.8MB 4.8MB +99.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jportner jportner merged commit afa9557 into elastic:main Feb 24, 2022
@jportner jportner deleted the fix-url-parse branch February 24, 2022 05:56
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants