-
Notifications
You must be signed in to change notification settings - Fork 861
Line icons addition #5633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line icons addition #5633
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5633/ |
elizabetdev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @MichaelMarcialis for adding this new great set of icons to EUI! 🎉
The icons look good to me. But I noticed that the lineDotted looks thinner when compared with the other two.
What do you think of instead of making a circle of 2px x 2px making it instead with 3px x 3px. This change makes the circles bigger with more space between them, and it's easier to notice that they are dots.
I guess one of the reasons you went with the 2px x 2px circles version is that they get better centered aligned. The 3px x 3px doesn't get centered properly but when is side by side with the other icons it doesn't make that much difference.
Let me know what do you think of the proposed changes?
Thanks for the feedback, @miukimiu! I've updated the |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5633/ |
elizabetdev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @MichaelMarcialis.
Tested in Safari, Firefox, and Chrome. Also tested in low resolution and LGTM! 🎉



Summary
Added new
lineDashed,lineDotted, andlineSolidicons to EUI.CCing @mbondyra, as elastic/kibana#124970 mentions needing these icons as part of the proposed design updates to Lens flyouts.
Checklist