[Fleet] Fix agent logs not reading query from URL by hop-dev · Pull Request #117286 · elastic/kibana

hop-dev · 2021-11-03T11:40:33Z

Summary

In #106267 we converted Fleet routing to not use hashes. We then moved to not reading the agent logs state from the URL hash in #109982 but the URL state storage connector was still storing the query using the hash, causing a mismatch.

elasticmachine · 2021-11-03T11:40:38Z

Pinging @elastic/fleet (Team:Fleet)

hop-dev · 2021-11-03T11:41:07Z

...gins/kibana_utils/public/state_sync/state_sync_state_storage/create_kbn_url_state_storage.ts

    onSetError,
  }: {
-    useHash: boolean;
+    useHash?: boolean;


This param is defaulted so I believe can be set as optional?

Probably a viable change, but if code owner review becomes a blocker maybe we should consider reverting and landing the other small change.

I'm not 100% sure why this was marked as required at the time, perhaps it is because this functionality was "experimental" and is often tied to an advanced setting, e.g.:

useHash: coreStart.uiSettings.get('state:storeInSessionStorage')

and the default would one day change.

@Dosant can confirm when is back next week. This looks like a safe change to make though, but I would advise waiting until he gets back next week or unblocking by not making this change now per @kpollich .

Brill thanks @jloleysens I'll work around it for now 👍

kpollich

LGTM 🚀

kpollich · 2021-11-03T12:27:05Z

...gins/kibana_utils/public/state_sync/state_sync_state_storage/create_kbn_url_state_storage.ts

    onSetError,
  }: {
-    useHash: boolean;
+    useHash?: boolean;


Probably a viable change, but if code owner review becomes a blocker maybe we should consider reverting and landing the other small change.

jloleysens

LGTM!

kibanamachine · 2021-11-04T17:00:30Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	615.7KB	615.8KB	+28.0B

History

💚 Build #3933 succeeded 7b787a0

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @hop-dev

* Don't use hash for agent logs url state * revert core app services change

kibanamachine · 2021-11-04T17:04:15Z

💚 Backport successful

Status	Branch	Result
✅	8.0
✅	7.16

The backport PRs will be merged automatically after passing CI.

* Don't use hash for agent logs url state * revert core app services change Co-authored-by: Mark Hopkin <mark.hopkin@elastic.co>

…ink-to-kibana-app * 'main' of github.com:elastic/kibana: (290 commits) [Connectors][ServiceNow] Remove SN flags (elastic#117511) [ML] Functional tests - stabilize and re-enable feature importance tests (elastic#117503) [RAC] Disable the actions button if the user has inadequate privileges (elastic#117488) [Visualize] [xyChart] filter labels by default (elastic#117288) Fix warning when setting description to undefined (elastic#117338) [build] Set monitoring.ui.container.elasticsearch.enabled for all containers (elastic#115087) fix types [Alerting] UX fixes for execution duration chart (elastic#117193) [CI] Delete node_modules in between bootstrap attempts (elastic#117588) Flaky test fixes (elastic#117028) [Security Solution] [Sourcerer] [Feature Branch] Update to use Kibana Data Views (elastic#114806) [ML] Hide anomaly entity filter button tooltips when clicked (elastic#117493) adjust the synthetics journey type (elastic#117316) Refines hasAnyData check for alerts (elastic#117499) [Fleet] Default to APM tutorial (elastic#117421) [Maps] update docs for index pattern -> data view rename (elastic#117400) [Logs UI][Metrics UI] Remove deprecated config fields from APIs and SavedObjects (elastic#116821) [Fleet] Fix agent logs not reading query from URL (elastic#117286) Fixing Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should successfully test valid es_query alert (elastic#114917) [Metrics UI] Add docs link to redundant groupBy detection (elastic#116822) ... # Conflicts: # x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap # x-pack/plugins/reporting/public/shared_imports.ts # x-pack/plugins/reporting/server/routes/management/jobs.ts

kibanamachine · 2021-11-08T17:09:49Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine · 2021-11-09T17:19:48Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine · 2021-11-10T17:29:48Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@miltonhultgren

…117568) * [Fleet] Fix agent logs not reading query from URL (#117286) * Don't use hash for agent logs url state * revert core app services change * Cherrypick changes from PR #115192 Backport @miltonhultgren's changes to add the `useHashQuery` param to `createKbnUrlStateStorage` Co-authored-by: Milton Hultgren <milton.hultgren@elastic.co> Co-authored-by: Mark Hopkin <mark.hopkin@elastic.co> Co-authored-by: Milton Hultgren <milton.hultgren@elastic.co>

Don't use hash for agent logs url state

7b787a0

hop-dev added release_note:fix v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 v8.1.0 labels Nov 3, 2021

hop-dev self-assigned this Nov 3, 2021

hop-dev requested review from a team as code owners November 3, 2021 11:40

botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Nov 3, 2021

hop-dev commented Nov 3, 2021

View reviewed changes

kpollich approved these changes Nov 3, 2021

View reviewed changes

revert core app services change

7138566

hop-dev enabled auto-merge (squash) November 4, 2021 15:04

jloleysens approved these changes Nov 4, 2021

View reviewed changes

hop-dev merged commit 9bc2f22 into elastic:main Nov 4, 2021

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 4, 2021

[Fleet] Fix agent logs not reading query from URL (elastic#117286)

9e52c1b

* Don't use hash for agent logs url state * revert core app services change

kibanamachine mentioned this pull request Nov 4, 2021

[8.0] [Fleet] Fix agent logs not reading query from URL (#117286) #117565

Merged

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 4, 2021

[Fleet] Fix agent logs not reading query from URL (elastic#117286)

fd67eac

* Don't use hash for agent logs url state * revert core app services change

kibanamachine mentioned this pull request Nov 4, 2021

[7.16] [Fleet] Fix agent logs not reading query from URL (#117286) #117568

Merged

kibanamachine added a commit that referenced this pull request Nov 4, 2021

[Fleet] Fix agent logs not reading query from URL (#117286) (#117565)

5b6d3c5

* Don't use hash for agent logs url state * revert core app services change Co-authored-by: Mark Hopkin <mark.hopkin@elastic.co>

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 8, 2021

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 11, 2021

Conversation

hop-dev commented Nov 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

elasticmachine commented Nov 3, 2021

Uh oh!

hop-dev Nov 3, 2021

Choose a reason for hiding this comment

Uh oh!

kpollich Nov 3, 2021

Choose a reason for hiding this comment

Uh oh!

jloleysens Nov 4, 2021

Choose a reason for hiding this comment

Uh oh!

hop-dev Nov 4, 2021

Choose a reason for hiding this comment

Uh oh!

kpollich left a comment

Choose a reason for hiding this comment

Uh oh!

kpollich Nov 3, 2021

Choose a reason for hiding this comment

Uh oh!

jloleysens left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Nov 4, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

History

Uh oh!

kibanamachine commented Nov 4, 2021

💚 Backport successful

Uh oh!

kibanamachine commented Nov 8, 2021

Uh oh!

kibanamachine commented Nov 9, 2021

Uh oh!

kibanamachine commented Nov 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hop-dev commented Nov 3, 2021 •

edited

Loading