[Metrics UI] Add docs link to redundant groupBy detection by Zacqary · Pull Request #116822 · elastic/kibana

Zacqary · 2021-10-29T18:14:14Z

REDO OF #116695 which was accidentally merged before approval

Summary

Fixes #116195

UPDATE

Instead of changing the logic, this PR will now add a docs link explaining how filtering and groupBy works.

Depends on this docs PR: elastic/observability-docs#1196

Previous Summary

~~In this PR, host.name will still be flagged as redundant in this case:~~

~~But with these changes, it will NOT be flagged in this case:~~

elasticmachine · 2021-10-29T18:14:16Z

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx

…ts/expression.tsx Co-authored-by: Sandra G <neptunian@users.noreply.github.com>

Zacqary · 2021-11-04T14:54:48Z

@elasticmachine merge upstream

kibanamachine · 2021-11-04T16:54:16Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`infra`	921.8KB	922.1KB	+314.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	267.1KB	267.1KB	-51.0B

History

💚 Build #3423 succeeded 5856bae
💚 Build #3336 succeeded aece73e
💚 Build #2907 succeeded 54e79ce

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…6822) * [Metrics UI] Fix OR logic on redundant groupBy detection * Switch regex change to doc change * Fix core docs links * Update x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx Co-authored-by: Sandra G <neptunian@users.noreply.github.com> Co-authored-by: Sandra G <neptunian@users.noreply.github.com>

kibanamachine · 2021-11-04T16:57:52Z

💚 Backport successful

Status	Branch	Result
✅	8.0
✅	7.16

The backport PRs will be merged automatically after passing CI.

…117563) * [Metrics UI] Fix OR logic on redundant groupBy detection * Switch regex change to doc change * Fix core docs links * Update x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx Co-authored-by: Sandra G <neptunian@users.noreply.github.com> Co-authored-by: Sandra G <neptunian@users.noreply.github.com> Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com> Co-authored-by: Sandra G <neptunian@users.noreply.github.com>

…117564) * [Metrics UI] Fix OR logic on redundant groupBy detection * Switch regex change to doc change * Fix core docs links * Update x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx Co-authored-by: Sandra G <neptunian@users.noreply.github.com> Co-authored-by: Sandra G <neptunian@users.noreply.github.com> Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com> Co-authored-by: Sandra G <neptunian@users.noreply.github.com>

…ink-to-kibana-app * 'main' of github.com:elastic/kibana: (290 commits) [Connectors][ServiceNow] Remove SN flags (elastic#117511) [ML] Functional tests - stabilize and re-enable feature importance tests (elastic#117503) [RAC] Disable the actions button if the user has inadequate privileges (elastic#117488) [Visualize] [xyChart] filter labels by default (elastic#117288) Fix warning when setting description to undefined (elastic#117338) [build] Set monitoring.ui.container.elasticsearch.enabled for all containers (elastic#115087) fix types [Alerting] UX fixes for execution duration chart (elastic#117193) [CI] Delete node_modules in between bootstrap attempts (elastic#117588) Flaky test fixes (elastic#117028) [Security Solution] [Sourcerer] [Feature Branch] Update to use Kibana Data Views (elastic#114806) [ML] Hide anomaly entity filter button tooltips when clicked (elastic#117493) adjust the synthetics journey type (elastic#117316) Refines hasAnyData check for alerts (elastic#117499) [Fleet] Default to APM tutorial (elastic#117421) [Maps] update docs for index pattern -> data view rename (elastic#117400) [Logs UI][Metrics UI] Remove deprecated config fields from APIs and SavedObjects (elastic#116821) [Fleet] Fix agent logs not reading query from URL (elastic#117286) Fixing Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should successfully test valid es_query alert (elastic#114917) [Metrics UI] Add docs link to redundant groupBy detection (elastic#116822) ... # Conflicts: # x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap # x-pack/plugins/reporting/public/shared_imports.ts # x-pack/plugins/reporting/server/routes/management/jobs.ts

[Metrics UI] Fix OR logic on redundant groupBy detection

54e79ce

Zacqary added release_note:fix v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Oct 29, 2021

Zacqary requested a review from a team as a code owner October 29, 2021 18:14

Zacqary added the v8.1.0 label Oct 29, 2021

Zacqary added 3 commits November 1, 2021 11:46

Switch regex change to doc change

ed09b2a

Merge branch 'main' into 116195-groupby-or-fix

c743588

Fix core docs links

aece73e

Zacqary requested a review from a team as a code owner November 1, 2021 17:49

lukeelmers approved these changes Nov 1, 2021

View reviewed changes

Zacqary changed the title ~~[Metrics UI] Fix OR logic on redundant groupBy detection~~ [Metrics UI] Add docs link to redundant groupBy detection Nov 1, 2021

Zacqary requested a review from neptunian November 1, 2021 20:02

neptunian reviewed Nov 1, 2021

View reviewed changes

x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx Outdated Show resolved Hide resolved

Update x-pack/plugins/infra/public/alerting/metric_threshold/componen…

5856bae

…ts/expression.tsx Co-authored-by: Sandra G <neptunian@users.noreply.github.com>

neptunian approved these changes Nov 2, 2021

View reviewed changes

Zacqary mentioned this pull request Nov 3, 2021

[Metrics UI] Threshold alert redundant groupBy throws a false positive on OR matches #116195

Closed

Merge branch 'main' into 116195-groupby-or-fix

018a4ea

Zacqary enabled auto-merge (squash) November 4, 2021 14:54

Zacqary merged commit e4982fe into elastic:main Nov 4, 2021

kibanamachine mentioned this pull request Nov 4, 2021

[8.0] [Metrics UI] Add docs link to redundant groupBy detection (#116822) #117563

Merged

kibanamachine mentioned this pull request Nov 4, 2021

[7.16] [Metrics UI] Add docs link to redundant groupBy detection (#116822) #117564

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Metrics UI] Add docs link to redundant groupBy detection#116822

[Metrics UI] Add docs link to redundant groupBy detection#116822
Zacqary merged 6 commits intoelastic:mainfrom
Zacqary:116195-groupby-or-fix

Zacqary commented Oct 29, 2021 •

edited

Loading

Uh oh!

elasticmachine commented Oct 29, 2021

Uh oh!

Uh oh!

Zacqary commented Nov 4, 2021

Uh oh!

kibanamachine commented Nov 4, 2021

Uh oh!

kibanamachine commented Nov 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Zacqary commented Oct 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

UPDATE

Previous Summary

Uh oh!

elasticmachine commented Oct 29, 2021

Uh oh!

Uh oh!

Zacqary commented Nov 4, 2021

Uh oh!

kibanamachine commented Nov 4, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

kibanamachine commented Nov 4, 2021

💚 Backport successful

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Zacqary commented Oct 29, 2021 •

edited

Loading