Merged
Conversation
smith
added
auto-backport
| jest.resetAllMocks(); | ||
| }); | ||
|
|
||
| it('should render services, when list is not empty', async () => { |
Contributor
There was a problem hiding this comment.
Are all these tests flaky?
Contributor
Author
There was a problem hiding this comment.
They were not, but they also were testing the things that we're already testing in https://github.com/elastic/kibana/blob/main/x-pack/plugins/apm/public/components/app/service_inventory/service_list/service_list.test.tsx.
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
Contributor
💛 Build succeeded, but was flaky
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
sorenlouv
approved these changes
Nov 4, 2021
Contributor
|
The following labels were identified as gaps in your version labels and will be added automatically:
If any of these should not be on your pull request, please manually remove them. |
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Nov 4, 2021
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 5, 2021
…ink-to-kibana-app * 'main' of github.com:elastic/kibana: (290 commits) [Connectors][ServiceNow] Remove SN flags (elastic#117511) [ML] Functional tests - stabilize and re-enable feature importance tests (elastic#117503) [RAC] Disable the actions button if the user has inadequate privileges (elastic#117488) [Visualize] [xyChart] filter labels by default (elastic#117288) Fix warning when setting description to undefined (elastic#117338) [build] Set monitoring.ui.container.elasticsearch.enabled for all containers (elastic#115087) fix types [Alerting] UX fixes for execution duration chart (elastic#117193) [CI] Delete node_modules in between bootstrap attempts (elastic#117588) Flaky test fixes (elastic#117028) [Security Solution] [Sourcerer] [Feature Branch] Update to use Kibana Data Views (elastic#114806) [ML] Hide anomaly entity filter button tooltips when clicked (elastic#117493) adjust the synthetics journey type (elastic#117316) Refines hasAnyData check for alerts (elastic#117499) [Fleet] Default to APM tutorial (elastic#117421) [Maps] update docs for index pattern -> data view rename (elastic#117400) [Logs UI][Metrics UI] Remove deprecated config fields from APIs and SavedObjects (elastic#116821) [Fleet] Fix agent logs not reading query from URL (elastic#117286) Fixing Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should successfully test valid es_query alert (elastic#114917) [Metrics UI] Add docs link to redundant groupBy detection (elastic#116822) ... # Conflicts: # x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap # x-pack/plugins/reporting/public/shared_imports.ts # x-pack/plugins/reporting/server/routes/management/jobs.ts
smith
added a commit
to smith/kibana
that referenced
this pull request
Dec 7, 2021
# Conflicts: # x-pack/plugins/apm/public/components/app/service_inventory/service_inventory.test.tsx # x-pack/plugins/apm/public/components/app/service_overview/service_overview.test.tsx
smith
added a commit
that referenced
this pull request
Dec 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Jest tests for service overview and service inventory with Storybook-based Jest tests.
Removes some specific tests and just does a basic render. Some of the tests were testing components like the list which are tested elsewhere. More tests can be added in the future to improve coverage. The coverage has decreased slightly in some places, but this gives us a cleaner base to improve upon.
Fixes #116532. Fixes #115685.