[Logs UI][Metrics UI] Remove deprecated config fields from APIs and SavedObjects by Zacqary · Pull Request #116821 · elastic/kibana

Zacqary · 2021-10-29T18:11:51Z

REDO OF #115874 which accidentally merged before approval

Summary

Closes #115257
Closes #115259
Closes #115254
Closes #115252

Removes remaining references to the deprecated fields timestamp, tiebreaker, container, pod, host from APIs and Saved Objects.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

…-fields-removal

…-fields-removal # Conflicts: # x-pack/plugins/infra/public/alerting/metric_threshold/components/expression_chart.test.tsx # x-pack/plugins/infra/public/lib/lib.ts # x-pack/plugins/infra/server/services/log_entries/log_entry_search_strategy.ts # x-pack/test/api_integration/apis/metrics_ui/metrics_alerting.ts

…-fields-removal

…them all

…ields-removal

elasticmachine · 2021-10-29T18:11:53Z

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

Zacqary · 2021-10-29T20:49:44Z

@simianhacker @Kerry350 Can I get another look at this? Original PR merged accidentally so I had to reopen this after a revert

Kerry350

Logs changes LGTM pending one question.

Kerry350 · 2021-11-01T12:56:04Z

x-pack/plugins/infra/common/log_sources/resolved_log_source_configuration.ts

    indices: indexPattern.title,
-    timestampField: indexPattern.timeFieldName ?? '@timestamp',
-    tiebreakerField: '_doc',
+    timestampField: TIMESTAMP_FIELD,


Thanks for making these changes based on the feedback from the other PR.

I think for the data view / KIP version we still want to read from the data view itself first.

timestampField: indexPattern.timeFieldName ?? TIMESTAMP_FIELD

(@weltenwort Would you say this is right, to honour the data view setting first? Or do we always want to go with the ECS constant?)

Yes, I'd agree that we still want to use the data view's timeFieldName in that case. 👍

…ields-removal

Zacqary · 2021-11-04T14:53:08Z

@elasticmachine merge upstream

phillipb

LGTM!

kibanamachine · 2021-11-04T17:57:23Z

💛 Build succeeded, but was flaky

Test Failures

[job] [logs] Default CI Group #4 / lens app lens formula should transition from count to formula

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`infra`	921.8KB	920.4KB	-1.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`infra`	90.2KB	90.3KB	+69.0B

History

💛 Build #3268 was flaky 31bd144
💚 Build #2904 succeeded facdac6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Zacqary

…avedObjects (elastic#116821) * [Logs UI][Metrics UI] Remove deprecated config fields from APIs * Fix typecheck * Fix typecheck * Fix typecheck * Fix jest * Fix functional test * Remove extraneous timeField args * Typecheck fix * Consolidate log file changes to ResolvedLogSourceConfiguration * Fix merge * Revert additional logs files * Revert inventory models * Revert log_analysis api * Fix timefield reference in process list * Restore logs page files, fix typecheck on mock * Fix functional test * Restore inventory models index * Fix typecheck on getFilteredMetrics * Look CI if you don't tell me all the type errors at once I can't fix them all * Maybe this is the last typecheck fix who knows * Restore reading timestamp field from data view Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-11-04T18:04:45Z

💔 Backport failed

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 116821

…avedObjects (#116821) (#117573) * [Logs UI][Metrics UI] Remove deprecated config fields from APIs * Fix typecheck * Fix typecheck * Fix typecheck * Fix jest * Fix functional test * Remove extraneous timeField args * Typecheck fix * Consolidate log file changes to ResolvedLogSourceConfiguration * Fix merge * Revert additional logs files * Revert inventory models * Revert log_analysis api * Fix timefield reference in process list * Restore logs page files, fix typecheck on mock * Fix functional test * Restore inventory models index * Fix typecheck on getFilteredMetrics * Look CI if you don't tell me all the type errors at once I can't fix them all * Maybe this is the last typecheck fix who knows * Restore reading timestamp field from data view Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…ink-to-kibana-app * 'main' of github.com:elastic/kibana: (290 commits) [Connectors][ServiceNow] Remove SN flags (elastic#117511) [ML] Functional tests - stabilize and re-enable feature importance tests (elastic#117503) [RAC] Disable the actions button if the user has inadequate privileges (elastic#117488) [Visualize] [xyChart] filter labels by default (elastic#117288) Fix warning when setting description to undefined (elastic#117338) [build] Set monitoring.ui.container.elasticsearch.enabled for all containers (elastic#115087) fix types [Alerting] UX fixes for execution duration chart (elastic#117193) [CI] Delete node_modules in between bootstrap attempts (elastic#117588) Flaky test fixes (elastic#117028) [Security Solution] [Sourcerer] [Feature Branch] Update to use Kibana Data Views (elastic#114806) [ML] Hide anomaly entity filter button tooltips when clicked (elastic#117493) adjust the synthetics journey type (elastic#117316) Refines hasAnyData check for alerts (elastic#117499) [Fleet] Default to APM tutorial (elastic#117421) [Maps] update docs for index pattern -> data view rename (elastic#117400) [Logs UI][Metrics UI] Remove deprecated config fields from APIs and SavedObjects (elastic#116821) [Fleet] Fix agent logs not reading query from URL (elastic#117286) Fixing Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should successfully test valid es_query alert (elastic#114917) [Metrics UI] Add docs link to redundant groupBy detection (elastic#116822) ... # Conflicts: # x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap # x-pack/plugins/reporting/public/shared_imports.ts # x-pack/plugins/reporting/server/routes/management/jobs.ts

tobiasstadler · 2021-11-09T14:19:59Z

@Zacqary Shouldn't docs/settings/general-infra-logs-ui-settings.asciidoc be removed or at leaset the xpack.infra.sources.default${field} settings in it?

Zacqary added 25 commits October 20, 2021 13:02

[Logs UI][Metrics UI] Remove deprecated config fields from APIs

54ec71a

Fix typecheck

9f4847d

Fix typecheck

00bdeaf

Fix typecheck

ae36941

Fix jest

0a2c206

Fix functional test

c0f907f

Merge remote-tracking branch 'upstream/master' into 115257-deprecated…

b2de461

…-fields-removal

Merge remote-tracking branch 'upstream/master' into 115257-deprecated…

d305db0

…-fields-removal

Remove extraneous timeField args

015793c

Typecheck fix

7a65545

Consolidate log file changes to ResolvedLogSourceConfiguration

2c8addf

Fix merge

38c6a1b

Merge remote-tracking branch 'upstream/master' into 115257-deprecated…

9b54051

…-fields-removal

Revert additional logs files

bddc9ca

Revert inventory models

f91a05e

Revert log_analysis api

bd2f062

Fix timefield reference in process list

951160e

Restore logs page files, fix typecheck on mock

077f9c1

Fix functional test

ed5825a

Restore inventory models index

c3d5af7

Fix typecheck on getFilteredMetrics

245ef33

Look CI if you don't tell me all the type errors at once I can't fix …

8e8350a

…them all

Maybe this is the last typecheck fix who knows

2b01e7f

Merge remote-tracking branch 'upstream/main' into 115257-deprecated-f…

facdac6

…ields-removal

Zacqary added release_note:breaking Feature:Metrics UI Metrics UI feature v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Oct 29, 2021

Zacqary requested a review from a team as a code owner October 29, 2021 18:11

Zacqary added v8.1.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Oct 29, 2021

Kerry350 self-requested a review November 1, 2021 12:33

Kerry350 approved these changes Nov 1, 2021

View reviewed changes

Merge remote-tracking branch 'upstream/main' into 115257-deprecated-f…

31bd144

…ields-removal

jasonrhodes assigned Zacqary Nov 2, 2021

Merge branch 'main' into 115257-deprecated-fields-removal

7488a40

Zacqary enabled auto-merge (squash) November 4, 2021 14:53

Zacqary disabled auto-merge November 4, 2021 14:53

phillipb approved these changes Nov 4, 2021

View reviewed changes

Restore reading timestamp field from data view

f362f84

Zacqary enabled auto-merge (squash) November 4, 2021 15:09

Zacqary merged commit 8420094 into elastic:main Nov 4, 2021

Zacqary mentioned this pull request Nov 4, 2021

[8.0] [Logs UI][Metrics UI] Remove deprecated config fields from APIs and SavedObjects (#116821) #117573

Merged

weltenwort mentioned this pull request Apr 20, 2022

[Infra UI] Removed source config settings are still present in the Kibana docs #130673

Closed

weltenwort mentioned this pull request May 11, 2023

[Logs UI] Register Logs UI Locators #155156

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Logs UI][Metrics UI] Remove deprecated config fields from APIs and SavedObjects#116821

[Logs UI][Metrics UI] Remove deprecated config fields from APIs and SavedObjects#116821
Zacqary merged 28 commits intoelastic:mainfrom
Zacqary:115257-deprecated-fields-removal

Zacqary commented Oct 29, 2021

Uh oh!

elasticmachine commented Oct 29, 2021

Uh oh!

Zacqary commented Oct 29, 2021

Uh oh!

Kerry350 left a comment

Uh oh!

Kerry350 Nov 1, 2021

Uh oh!

weltenwort Nov 1, 2021

Uh oh!

Zacqary commented Nov 4, 2021

Uh oh!

phillipb left a comment

Uh oh!

kibanamachine commented Nov 4, 2021

Uh oh!

kibanamachine commented Nov 4, 2021

Uh oh!

tobiasstadler commented Nov 9, 2021 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

Zacqary commented Oct 29, 2021

Summary

Checklist

Uh oh!

elasticmachine commented Oct 29, 2021

Uh oh!

Zacqary commented Oct 29, 2021

Uh oh!

Kerry350 left a comment

Choose a reason for hiding this comment

Uh oh!

Kerry350 Nov 1, 2021

Choose a reason for hiding this comment

Uh oh!

weltenwort Nov 1, 2021

Choose a reason for hiding this comment

Uh oh!

Zacqary commented Nov 4, 2021

Uh oh!

phillipb left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Nov 4, 2021

💛 Build succeeded, but was flaky

Test Failures

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

kibanamachine commented Nov 4, 2021

💔 Backport failed

Uh oh!

tobiasstadler commented Nov 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

tobiasstadler commented Nov 9, 2021 •

edited

Loading