Skip to content

[Alerting] UX fixes for execution duration chart#117193

Merged
ymao1 merged 6 commits intoelastic:mainfrom
ymao1:alerting/rule-execution-duration-nicer
Nov 4, 2021
Merged

[Alerting] UX fixes for execution duration chart#117193
ymao1 merged 6 commits intoelastic:mainfrom
ymao1:alerting/rule-execution-duration-nicer

Conversation

@ymao1
Copy link
Copy Markdown
Contributor

@ymao1 ymao1 commented Nov 2, 2021

Resolves #117009
Resolves #117007
Resolves #115965

Summary

UX fixes to the rule execution duration chart:

  • Nicer labels on the tooltip

Screen Shot 2021-11-02 at 1 40 02 PM

  • Remove tooltip for empty executions (these are placeholders so the bars stay a consistent width.

Screen Shot 2021-11-02 at 1 40 07 PM

  • Adding min bar height so if execution duration spikes, previous durations will still be visible

Screen Shot 2021-11-02 at 1 43 53 PM

@ymao1 ymao1 self-assigned this Nov 2, 2021
@ymao1 ymao1 added Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.16.0 v8.0.0 v8.1.0 labels Nov 2, 2021
@ymao1 ymao1 marked this pull request as ready for review November 2, 2021 17:58
@ymao1 ymao1 requested a review from a team as a code owner November 2, 2021 17:58
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@ymao1
Copy link
Copy Markdown
Contributor Author

ymao1 commented Nov 2, 2021

@elasticmachine merge upstream

@ymao1
Copy link
Copy Markdown
Contributor Author

ymao1 commented Nov 2, 2021

@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the changes!

@ymao1
Copy link
Copy Markdown
Contributor Author

ymao1 commented Nov 4, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 776.8KB 777.1KB +278.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ymao1

@ymao1 ymao1 added the auto-backport Deprecated - use backport:version if exact versions are needed label Nov 4, 2021
@ymao1 ymao1 merged commit eb99e5e into elastic:main Nov 4, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 4, 2021
* UX fixes for duration chart

* UX fixes for duration chart

* UX fixes for duration chart

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 4, 2021
* UX fixes for duration chart

* UX fixes for duration chart

* UX fixes for duration chart

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Backport successful

Status Branch Result
8.0
7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 4, 2021
* UX fixes for duration chart

* UX fixes for duration chart

* UX fixes for duration chart

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: ymao1 <ying.mao@elastic.co>
kibanamachine added a commit that referenced this pull request Nov 5, 2021
* UX fixes for duration chart

* UX fixes for duration chart

* UX fixes for duration chart

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: ymao1 <ying.mao@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 5, 2021
…ink-to-kibana-app

* 'main' of github.com:elastic/kibana: (290 commits)
  [Connectors][ServiceNow] Remove SN flags (elastic#117511)
  [ML] Functional tests - stabilize and re-enable feature importance tests (elastic#117503)
  [RAC] Disable the actions button if the user has inadequate privileges (elastic#117488)
  [Visualize] [xyChart] filter labels by default (elastic#117288)
  Fix warning when setting description to undefined (elastic#117338)
  [build] Set monitoring.ui.container.elasticsearch.enabled for all containers (elastic#115087)
  fix types
  [Alerting] UX fixes for execution duration chart (elastic#117193)
  [CI] Delete node_modules in between bootstrap attempts (elastic#117588)
  Flaky test fixes (elastic#117028)
  [Security Solution] [Sourcerer] [Feature Branch] Update to use Kibana Data Views  (elastic#114806)
  [ML] Hide anomaly entity filter button tooltips when clicked (elastic#117493)
  adjust the synthetics journey type (elastic#117316)
  Refines hasAnyData check for alerts (elastic#117499)
  [Fleet] Default to APM tutorial (elastic#117421)
  [Maps] update docs for index pattern -> data view rename (elastic#117400)
  [Logs UI][Metrics UI] Remove deprecated config fields from APIs and SavedObjects (elastic#116821)
  [Fleet] Fix agent logs not reading query from URL (elastic#117286)
  Fixing Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should successfully test valid es_query alert (elastic#114917)
  [Metrics UI] Add docs link to redundant groupBy detection (elastic#116822)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap
#	x-pack/plugins/reporting/public/shared_imports.ts
#	x-pack/plugins/reporting/server/routes/management/jobs.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.16.0 v8.0.0 v8.1.0

Projects

None yet

4 participants