Skip to content

[CI] Delete node_modules in between bootstrap attempts#117588

Merged
brianseeders merged 1 commit intoelastic:mainfrom
brianseeders:delete-node-modules-on-retry
Nov 4, 2021
Merged

[CI] Delete node_modules in between bootstrap attempts#117588
brianseeders merged 1 commit intoelastic:mainfrom
brianseeders:delete-node-modules-on-retry

Conversation

@brianseeders
Copy link
Copy Markdown
Contributor

@brianseeders brianseeders commented Nov 4, 2021 •
edited
Loading

When bootstrap fails, it usually results in a problem inside node_modules that is not corrected on the next bootstrap. This is likely because of postinstall scripts that don't run.

See here for an example: https://buildkite.com/elastic/kibana-on-merge/builds/7291#37f2ecc1-4dc5-4789-bac2-99e7dac1d560

We have lots of random failures in CI because of this. Deleting node_modules before the retry should fix the problem.

@brianseeders brianseeders added Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes v8.1.0 Team:Operations Kibana-Operations Team v7.15.2 v7.16.1 v8.0.0 labels Nov 4, 2021
@brianseeders brianseeders marked this pull request as ready for review November 4, 2021 19:26
@brianseeders brianseeders requested a review from a team as a code owner November 4, 2021 19:26
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 4, 2021

Pinging @elastic/kibana-operations (Team:Operations)

@brianseeders brianseeders enabled auto-merge (squash) November 4, 2021 19:29
tylersmalley
tylersmalley reviewed Nov 4, 2021
View reviewed changes
.buildkite/scripts/bootstrap.sh

# Most bootstrap failures will result in a problem inside node_modules that does not get fixed on the next bootstrap
# So, we should just delete node_modules in between attempts
rm -rf node_modules
Copy link
Copy Markdown
Member

@tylersmalley tylersmalley Nov 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to consider yarn kbn clean as it also resets things like Bazel if there were an issue there. But deleting node_modules should accomplish what we're looking to resolve there without possible side-effects clean might have.

Copy link
Copy Markdown
Member

@tylersmalley tylersmalley Nov 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though, if we used clean we would have to re-extract the plugins. So, nevermind.

Copy link
Copy Markdown
Contributor

@spalger spalger Nov 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I really hope that there's never a time where Bazel starts to handle failures like yarn does

@brianseeders brianseeders merged commit 22a9382 into elastic:main Nov 4, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Nov 4, 2021

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 5, 2021
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/add-l…
55c195e 
…ink-to-kibana-app

* 'main' of github.com:elastic/kibana: (290 commits)
  [Connectors][ServiceNow] Remove SN flags (elastic#117511)
  [ML] Functional tests - stabilize and re-enable feature importance tests (elastic#117503)
  [RAC] Disable the actions button if the user has inadequate privileges (elastic#117488)
  [Visualize] [xyChart] filter labels by default (elastic#117288)
  Fix warning when setting description to undefined (elastic#117338)
  [build] Set monitoring.ui.container.elasticsearch.enabled for all containers (elastic#115087)
  fix types
  [Alerting] UX fixes for execution duration chart (elastic#117193)
  [CI] Delete node_modules in between bootstrap attempts (elastic#117588)
  Flaky test fixes (elastic#117028)
  [Security Solution] [Sourcerer] [Feature Branch] Update to use Kibana Data Views  (elastic#114806)
  [ML] Hide anomaly entity filter button tooltips when clicked (elastic#117493)
  adjust the synthetics journey type (elastic#117316)
  Refines hasAnyData check for alerts (elastic#117499)
  [Fleet] Default to APM tutorial (elastic#117421)
  [Maps] update docs for index pattern -> data view rename (elastic#117400)
  [Logs UI][Metrics UI] Remove deprecated config fields from APIs and SavedObjects (elastic#116821)
  [Fleet] Fix agent logs not reading query from URL (elastic#117286)
  Fixing Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should successfully test valid es_query alert (elastic#114917)
  [Metrics UI] Add docs link to redundant groupBy detection (elastic#116822)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap
#	x-pack/plugins/reporting/public/shared_imports.ts
#	x-pack/plugins/reporting/server/routes/management/jobs.ts
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Nov 8, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 117588 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 8, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Nov 9, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 117588 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Nov 10, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 117588 or prevent reminders by adding the backport:skip label.

@brianseeders brianseeders added the auto-backport Deprecated - use backport:version if exact versions are needed label Nov 11, 2021
@kibanamachine kibanamachine mentioned this pull request Nov 11, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 11, 2021
@brianseeders @kibanamachine
[CI] Delete node_modules in between bootstrap attempts (elastic#117588)
879e6b3
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 11, 2021
@brianseeders @kibanamachine
[CI] Delete node_modules in between bootstrap attempts (elastic#117588)
bb5844a
@kibanamachine kibanamachine mentioned this pull request Nov 11, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 11, 2021
@brianseeders @kibanamachine
[CI] Delete node_modules in between bootstrap attempts (elastic#117588)
31ef67e
@kibanamachine kibanamachine mentioned this pull request Nov 11, 2021
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Nov 11, 2021

💚 Backport successful

Status Branch Result
✅ 8.0
✅ 7.15
✅ 7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 11, 2021
@kibanamachine @brianseeders
[CI] Delete node_modules in between bootstrap attempts (#117588) (#11…
99b2207 
…8279)

Co-authored-by: Brian Seeders <brian.seeders@elastic.co>
kibanamachine added a commit that referenced this pull request Nov 11, 2021
@kibanamachine @brianseeders
[CI] Delete node_modules in between bootstrap attempts (#117588) (#11…
4d9351f 
…8280)

Co-authored-by: Brian Seeders <brian.seeders@elastic.co>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 11, 2021
kibanamachine added a commit that referenced this pull request Nov 11, 2021
@kibanamachine @brianseeders
[CI] Delete node_modules in between bootstrap attempts (#117588) (#11…
22637f7 
…8281)

Co-authored-by: Brian Seeders <brian.seeders@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

+1 more reviewer

@spalger spalger spalger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.15.2 v7.16.1 v8.0.0 v8.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@brianseeders @elasticmachine @kibanamachine @tylersmalley @spalger