[Fleet] Fix agent logs filtering from URL state#109982
Merged
jen-huang merged 1 commit intoelastic:masterfrom Aug 25, 2021
Merged
[Fleet] Fix agent logs filtering from URL state#109982jen-huang merged 1 commit intoelastic:masterfrom
jen-huang merged 1 commit intoelastic:masterfrom
Conversation
jen-huang
added
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @jen-huang |
Contributor
|
The following labels were identified as gaps in your version labels and will be added automatically:
If any of these should not be on your pull request, please manually remove them. |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 25, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 25, 2021
Contributor
kibanamachine
added a commit
that referenced
this pull request
Aug 25, 2021
kibanamachine
added a commit
that referenced
this pull request
Aug 25, 2021
|
Hi @EricDavisX We are validating this PR in lieu of reported issue at #109402. We have validated this on 7.15 BC3 cloud-Prod build.
Screenshot: Build details: Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #109402
In #106267 we converted Fleet routing to not use hashes. For agent logs, we have links to pre-populate filters from the URL state. This is done by using Kibana's URL state management helper,
getStateFromKbnUrl, which by default assumes the state is stored in the hash part of the URL. This PR passes in the right argument to retrieve it from the main query instead.