Repository navigation
chore(release): v3.8.53 train v3 validation (do not merge) - #18956
Closed
diegosouzapw wants to merge 36 commits into
Closed
diegosouzapw wants to merge 36 commits into
diegosouzapw wants to merge 36 commits into
Conversation
|
Important Review skippedToo many files! This PR contains 419 files, which is 119 over the limit of 300. To get a review, reduce the PR to 300 files or fewer by splitting it into smaller PRs or changing its base branch. Usage-priced reviews support at most 300 files.
|
| assert.doesNotMatch(s, /from ["'](?:@\/|(?:\.\.\/)+src\/)lib\/usageDb/); | ||
| assert.match( | ||
| s, | ||
| new RegExp(`import \\{ saveCallLog \\} from "${specifier.replace(/[./]/g, "\\$&")}";`) |
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
Collaborator
Author
|
Superseded by 19015 (train v3 final: rebased on the current tip, integration fixes included). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation-only train for the v3.8.53 fix sweep (v3, second wave). Do not merge this PR.
Base:
release/v3.8.53(911e336b8040b6c4f697aa747b370da069909518). On top of it come 36 approved PRs, each as one squash commit with its final title, in merge order.Second-wave PRs were fixed against the release tip (maintainer commits on the contributor branches, credit kept). Where two train PRs touch the same lines, the later PR's branch gets a merge of its train predecessors with the resolution, so its GitHub squash lands exactly the train commit. After CI is green, each PR is squash-merged through GitHub in this order, the squash tree is compared with the matching train commit, and this PR is then closed.
Held out of this train: #18668 (its full-jitter set retry conflicts with the #18549 cancellable-wait tests) and #18347 (complexity ratchet and its own reactive-refresh tests).
PRs in order:
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.