Improve AWS credential loading and configuration handling in BedrockProvider #5627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbalicchia
force-pushed
the
addaws-profile
branch
from
3b50a83 to
374cb39
Compare
Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: Arya Pratap Singh <notaryasingh@gmail.com> Signed-off-by: fbalicchia <fbalicchia@gmail.com>
…block#5437) Signed-off-by: saiadithyaa <saiadithyaa2306@gmail.com> Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: Dakshata Mishra <dakshatamishralakshya@gmail.com> Signed-off-by: Dakshata <22-783@apsdhaulakuan.onmicrosoft.com> Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: Mohammad Shahzeb Alam <shahzebalam14feb@gmail.com> Co-authored-by: taniandjerry <126204004+taniandjerry@users.noreply.github.com> Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Co-authored-by: Douwe Osinga <douwe@squareup.com> Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: Anudhyan <127120520+Anudhyan@users.noreply.github.com> Signed-off-by: Anudhyan Datta <anudhyandatta2021@gmail.com>" Signed-off-by: Anudhyan Datta <anudhyandatta2021@gmail.com> Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: Shreyansh Singh Gautam <shreyanshrewa@gmail.com> Co-authored-by: taniandjerry <126204004+taniandjerry@users.noreply.github.com> Thank you so much for contributing this Hacktoberfest, Sheryansh! Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: fbalicchia <fbalicchia@gmail.com>
…with goose (block#5446) Signed-off-by: Lymah123 <fimihanodunola625@gmail.com> Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: fbalicchia <fbalicchia@gmail.com>
…ock#5195) Signed-off-by: Anthony D. Mays <anthony@morganlatimer.com> Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: Mohammed Thaha <mohammedthahacse@gmail.com> Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: Anthony D. Mays <anthony@morganlatimer.com> Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: Dakshata <22-783@apsdhaulakuan.onmicrosoft.com> Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: Dakshata <22-783@apsdhaulakuan.onmicrosoft.com> Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: Better-Boy <panaroma365@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: Better-Boy <panaroma365@gmail.com> Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: fbalicchia <fbalicchia@gmail.com>
…ion (block#5464) Signed-off-by: fbalicchia <fbalicchia@gmail.com>
…ck#5421) Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: Better-Boy <panaroma365@gmail.com> Signed-off-by: fbalicchia <fbalicchia@gmail.com>
…lock#5467) Signed-off-by: Lymah123 <fimihanodunola625@gmail.com> Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: Daniel Cooper <daniel@14lines.com> Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: Alex Holder <alexeeyre@gmail.com> Signed-off-by: fbalicchia <fbalicchia@gmail.com>
…or (block#5494) Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Co-authored-by: Douwe Osinga <douwe@squareup.com> Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Co-authored-by: Douwe Osinga <douwe@squareup.com> Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Co-authored-by: Douwe Osinga <douwe@squareup.com> Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com> Co-authored-by: Alex Hancock <alexhancock@block.xyz> Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Co-authored-by: Douwe Osinga <douwe@squareup.com> Signed-off-by: fbalicchia <fbalicchia@gmail.com>
…#5606) Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: fbalicchia <fbalicchia@gmail.com>
block#5616) Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com> Signed-off-by: fbalicchia <fbalicchia@gmail.com>
…r extension (block#5575) Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Auto-merged release PR after tag v1.13.0 was pushed Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: fbalicchia <fbalicchia@gmail.com>
…block#5082) Signed-off-by: fbalicchia <fbalicchia@gmail.com>
Signed-off-by: fbalicchia <fbalicchia@gmail.com>
…on (block#5625) Signed-off-by: fbalicchia <fbalicchia@gmail.com>
fbalicchia
force-pushed
the
addaws-profile
branch
from
374cb39 to
307b1d7
Compare
DOsinga
reviewed
Nov 7, 2025
Collaborator
DOsinga
left a comment
DOsinga
left a comment
There was a problem hiding this comment.
thanks for looking into this. I think you need to pull in main or something to clean up the diff
Collaborator
|
@fbalicchia Do you want to merge main or rebase and get this one ready to go in? |
Contributor
Author
|
I'm sorry alexhancock i'll do soon |
Contributor
Author
|
alexhancock Closing in favor of #5699 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the BedrockProvider::from_env implementation to make AWS configuration loading more robust and user-friendly, especially for environments using AWS SSO or multiple profiles.
⸻
Key Changes
• Replaced aws_config::load_from_env() with aws_config::defaults(BehaviorVersion::latest()) to support:
• AWS SSO logins (aws sso login --profile )
• Named profiles (AWS_PROFILE)
• Explicit region configuration (AWS_REGION)
• Added explicit handling for:
• AWS_PROFILE → sets the active AWS profile
• AWS_REGION → sets the AWS region dynamically