Configurable search paths #5356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #[cfg(windows)] | ||
| command.creation_flags(CREATE_NO_WINDOW_FLAG); | ||
|
|
||
| command.env( |
Collaborator
There was a problem hiding this comment.
this overrides the main $PATH right? so user would need to know to set everything they need as not appending? (can the config include $PATH as an auto expanding var?)
Collaborator
Author
There was a problem hiding this comment.
command.env overrides, but the search_path_var() function will do the appending
DOsinga
approved these changes
Oct 29, 2025
fbalicchia
pushed a commit
to fbalicchia/goose
that referenced
this pull request
Nov 7, 2025
Signed-off-by: fbalicchia <[email protected]>
10 tasks
BlairAllan
pushed a commit
to BlairAllan/goose
that referenced
this pull request
Nov 29, 2025
Signed-off-by: Blair Allan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets you set paths in your config to be appended to a PATH variable when Goose runs things. For now just extensions but perhaps we use this for other processes too, like cli providers?