-
Notifications
You must be signed in to change notification settings - Fork 2.3k
openapi to locust load test generator recipe #5447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Better-Boy <[email protected]>
|
❌ Recipe Validation Failed Please fix the validation errors and push your changes: ✅ openapi-to-locust.yaml: VALID\n❌ analyze-openapi.yaml: INVALID\n 📚 Check our Recipe Guide for help with the correct format. |
|
Thank you for the new PR, @Better-Boy ! And for addressing feedback. Pasting over my feedback from your previous PR to have as reference here |
taniandjerry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following needs to be addressed before this recipe can be merged:
- The DCO check is failing, which is required on all external contributions! You can follow instructions by clicking to see more details on the check. Let me know if you have questions on it!
- The recipe validation is failing. I believe this is because you are referencing
activitiesthat I don't believe are supported.sub_recipesis supported if that is what you were trying to do.
goose gave me the below examples:
Where you are using
activities:
- name: validate-openapi-spec
recipe: ./sub-recipes/validate-openapi-spec.yaml
inputs:
spec_path: "{{ openapi_spec_path }}"
outputs:
- spec_format
it could be something like
sub_recipes:
- name: test_sub_recipe
path: test_sub_recipe.yaml
values:
param1: value1
|
🔍 Recipe Security Scan Results ✅ Status: APPROVED - All recipes passed security scan 📊 Scan Summary:
📋 Individual Recipe Results: 🔗 View detailed scan results in the workflow artifacts. |
|
Signed-off-by: Better-Boy <[email protected]>
|
✅ Recipe Validation Passed Your recipe(s) are valid and ready for review! 🔍 Next Steps:
Thanks for contributing to the goose Recipe Cookbook! 🎉 |
|
🔍 Recipe Security Scan Results ❌ Status: BLOCKED - One or more recipes have MEDIUM risk or higher
📊 Scan Summary:
📋 Individual Recipe Results: 🔗 View detailed scan results in the workflow artifacts. |
|
There are security issues with your recent changes, tagging teammates to also help review further @blackgirlbytes @EbonyLouis @dianed-square |
Signed-off-by: Better-Boy <[email protected]>
|
✅ Recipe Validation Passed Your recipe(s) are valid and ready for review! 🔍 Next Steps:
Thanks for contributing to the goose Recipe Cookbook! 🎉 |
|
🔍 Recipe Security Scan Results ✅ Status: APPROVED - All recipes passed security scan 📊 Scan Summary:
📋 Individual Recipe Results: 🔗 View detailed scan results in the workflow artifacts. |
Looks like no security issue in the last run - #5447 (comment) |
taniandjerry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing the fixes! This looks good now. I see that the hardcoded credentials likely caused the security flag to pop up!
You fixed the recipe structure (activities → sub_recipes), the pathing, got that DCO check signed, and all the validation is passing! Thank you so much for your work and for contributing ❤️ ✅
* 'main' of github.com:block/goose: (81 commits) nextcamp - fix session resume when navigating back to chat in sidebar (#5370) feat/fix: set optional config params, and don't overwrite unset secrets (#5325) Stringly typed config (#5463) Fix: Compaction client <-> server sync (#5481) docs: recipe activity parameter substitution (#5462) only run fork on branch PRs (#5461) docs: video on goose with apify mcp (#5472) Clear windows and fix build failure (#5452) Add menu option for setting window always on top (#5429) Delete environment variable (#5479) chore: upgrade rmcp to 0.8.3 (#5458) docs: add "Building Custom Tools and Extensions for Goose" (#5469) Doc (Blog): Managing goose Configurations Across Multiple Projects (#5467) apify doc fix (#5460) Stream token usage on every agent message (#5342) rpm install in /opt/Goose to avoid conflicts with chrome-sandbox (#5421) Don't disable extensions after they fail to activate in new chat session (#5464) Add OTLP logs layer (#5386) openapi to locust load test generator recipe (#5447) technical debt tracker recipe (#5451) ... # Conflicts: # ui/desktop/src/components/ChatInput.tsx
Signed-off-by: Better-Boy <[email protected]> Signed-off-by: fbalicchia <[email protected]>
Signed-off-by: Better-Boy <[email protected]> Signed-off-by: Blair Allan <[email protected]>
Fixes #4725