Skip to content

Conversation

@Better-Boy
Copy link
Contributor

Fixes #4725

@Better-Boy Better-Boy requested a review from a team as a code owner October 29, 2025 17:13
@github-actions
Copy link
Contributor

Recipe Validation Failed

Please fix the validation errors and push your changes:

✅ openapi-to-locust.yaml: VALID\n❌ analyze-openapi.yaml: INVALID\n\nError: ✗ recipe file is invalid: Missing definitions for parameters in the recipe file: output_dir.\n\n❌ generate-locustfile.yaml: INVALID\n\nError: ✗ recipe file is invalid: Unnecessary parameter definitions: api_analysis, taskset_files.\n\n❌ generate-support-files.yaml: INVALID\n\nError: ✗ recipe file is invalid: Unnecessary parameter definitions: api_analysis.\n\n❌ generate-task-sets.yaml: INVALID\n\nError: ✗ recipe file is invalid: Unnecessary parameter definitions: api_analysis, openapi_spec_path.\n\n

📚 Check our Recipe Guide for help with the correct format.

@taniandjerry
Copy link
Contributor

taniandjerry commented Oct 29, 2025

Thank you for the new PR, @Better-Boy ! And for addressing feedback. Pasting over my feedback from your previous PR to have as reference here

@taniandjerry taniandjerry added hacktoberfest Issues awarding points for Hacktoberfest 2025! medium Weight label for Hacktoberfest 2025 issues labels Oct 29, 2025
Copy link
Contributor

@taniandjerry taniandjerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following needs to be addressed before this recipe can be merged:

  • The DCO check is failing, which is required on all external contributions! You can follow instructions by clicking to see more details on the check. Let me know if you have questions on it!
  • The recipe validation is failing. I believe this is because you are referencing activities that I don't believe are supported. sub_recipes is supported if that is what you were trying to do.

goose gave me the below examples:

Where you are using

activities:
  - name: validate-openapi-spec
    recipe: ./sub-recipes/validate-openapi-spec.yaml
    inputs:
      spec_path: "{{ openapi_spec_path }}"
    outputs:
      - spec_format

it could be something like

sub_recipes:
  - name: test_sub_recipe
    path: test_sub_recipe.yaml
    values:
      param1: value1

@github-actions
Copy link
Contributor

🔍 Recipe Security Scan Results

Status: APPROVED - All recipes passed security scan

📊 Scan Summary:

  • Total recipes scanned: 5

📋 Individual Recipe Results:
✅ Recipe 1: APPROVED (LOW risk)
✅ Recipe 2: APPROVED (LOW risk)
✅ Recipe 3: APPROVED (LOW risk)
✅ Recipe 4: APPROVED (LOW risk)
✅ Recipe 5: APPROVED (LOW risk)

🔗 View detailed scan results in the workflow artifacts.

@Better-Boy
Copy link
Contributor Author

Thank you for the new PR, @Better-Boy ! And for addressing feedback. Pasting over my feedback from your previous PR to have as reference here:

The following needs to be addressed before this recipe can be merged:

  • The DCO check is failing, which is required on all external contributions! You can follow instructions by clicking to see more details on the check. Let me know if you have questions on it!
  • The recipe validation is failing. I believe this is because you are referencing activities that I don't believe are supported. sub_recipes is supported if that is what you were trying to do.

goose gave me the below examples:

Where you are using

activities:
  - name: validate-openapi-spec
    recipe: ./sub-recipes/validate-openapi-spec.yaml
    inputs:
      spec_path: "{{ openapi_spec_path }}"
    outputs:
      - spec_format

it could be something like

sub_recipes:
  - name: test_sub_recipe
    path: test_sub_recipe.yaml
    values:
      param1: value1

@taniandjerry

  • DCO check done
  • the entire recipe is rewritten following the documentation
  • will fix the recipe validation issues

Signed-off-by: Better-Boy <[email protected]>
@github-actions
Copy link
Contributor

Recipe Validation Passed

Your recipe(s) are valid and ready for review!

🔍 Next Steps:

  1. Our team will review your recipe
  2. If approved, we'll run a security scan
  3. Once merged, you'll receive $10 in OpenRouter credits (if email provided)

Thanks for contributing to the goose Recipe Cookbook! 🎉

@github-actions
Copy link
Contributor

🔍 Recipe Security Scan Results

Status: BLOCKED - One or more recipes have MEDIUM risk or higher

⚠️ Merge Protection: This PR cannot be merged until security concerns are addressed.
Repository maintainers can override this decision if needed.

📊 Scan Summary:

  • Total recipes scanned: 5
  • Blocked recipes: 2

📋 Individual Recipe Results:
✅ Recipe 1: APPROVED (LOW risk)
✅ Recipe 2: APPROVED (LOW risk)
✅ Recipe 3: APPROVED (LOW risk)
✅ Recipe 4: APPROVED (LOW risk)
❌ Recipe 5: BLOCKED (CRITICAL risk)

🔗 View detailed scan results in the workflow artifacts.

@taniandjerry
Copy link
Contributor

There are security issues with your recent changes, tagging teammates to also help review further @blackgirlbytes @EbonyLouis @dianed-square

@github-actions
Copy link
Contributor

Recipe Validation Passed

Your recipe(s) are valid and ready for review!

🔍 Next Steps:

  1. Our team will review your recipe
  2. If approved, we'll run a security scan
  3. Once merged, you'll receive $10 in OpenRouter credits (if email provided)

Thanks for contributing to the goose Recipe Cookbook! 🎉

@github-actions
Copy link
Contributor

🔍 Recipe Security Scan Results

Status: APPROVED - All recipes passed security scan

📊 Scan Summary:

  • Total recipes scanned: 5

📋 Individual Recipe Results:
✅ Recipe 1: APPROVED (LOW risk)
✅ Recipe 2: APPROVED (LOW risk)
✅ Recipe 3: APPROVED (LOW risk)
✅ Recipe 4: APPROVED (LOW risk)
✅ Recipe 5: APPROVED (LOW risk)

🔗 View detailed scan results in the workflow artifacts.

@Better-Boy
Copy link
Contributor Author

There are security issues with your recent changes, tagging teammates to also help review further @blackgirlbytes @EbonyLouis @dianed-square

Looks like no security issue in the last run - #5447 (comment)

Copy link
Contributor

@taniandjerry taniandjerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the fixes! This looks good now. I see that the hardcoded credentials likely caused the security flag to pop up!

You fixed the recipe structure (activities → sub_recipes), the pathing, got that DCO check signed, and all the validation is passing! Thank you so much for your work and for contributing ❤️ ✅

@taniandjerry taniandjerry merged commit 3654a48 into block:main Oct 29, 2025
17 checks passed
zanesq added a commit that referenced this pull request Oct 30, 2025
* 'main' of github.com:block/goose: (81 commits)
  nextcamp - fix session resume when navigating back to chat in sidebar (#5370)
  feat/fix: set optional config params, and don't overwrite unset secrets (#5325)
  Stringly typed config (#5463)
  Fix: Compaction client <-> server sync  (#5481)
  docs: recipe activity parameter substitution (#5462)
  only run fork on branch PRs (#5461)
  docs: video on goose with apify mcp (#5472)
  Clear windows and fix build failure (#5452)
  Add menu option for setting window always on top (#5429)
  Delete environment variable (#5479)
  chore: upgrade rmcp to 0.8.3 (#5458)
  docs: add "Building Custom Tools and Extensions for Goose" (#5469)
  Doc (Blog): Managing goose Configurations Across Multiple Projects (#5467)
  apify doc fix (#5460)
  Stream token usage on every agent message (#5342)
  rpm install in /opt/Goose to avoid conflicts with chrome-sandbox (#5421)
  Don't disable extensions after they fail to activate in new chat session (#5464)
  Add OTLP logs layer (#5386)
  openapi to locust load test generator recipe (#5447)
  technical debt tracker recipe (#5451)
  ...

# Conflicts:
#	ui/desktop/src/components/ChatInput.tsx
fbalicchia pushed a commit to fbalicchia/goose that referenced this pull request Nov 7, 2025
BlairAllan pushed a commit to BlairAllan/goose that referenced this pull request Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest Issues awarding points for Hacktoberfest 2025! hacktoberfest-accepted medium Weight label for Hacktoberfest 2025 issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🍳 Advanced Recipe Submission #8

2 participants